Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Heartbeat interval not reset correctly in streaming endpoints. #6848

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #6837

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.07%. Comparing base (ce0396a) to head (1554d01).

Files with missing lines Patch % Lines
engine/access/state_stream/backend/handler.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6848   +/-   ##
=======================================
  Coverage   41.07%   41.07%           
=======================================
  Files        2120     2120           
  Lines      185958   185968   +10     
=======================================
+ Hits        76384    76393    +9     
  Misses     103156   103156           
- Partials     6418     6419    +1     
Flag Coverage Δ
unittests 41.07% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, but double check that test failure.

@Guitarheroua
Copy link
Contributor

If changes from this PR will be backported to v0.37, the flow-sdk should be definitely checked for issues

@peterargue peterargue added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@peterargue peterargue added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@peterargue peterargue requested a review from a team as a code owner January 21, 2025 23:51
@peterargue peterargue added this pull request to the merge queue Jan 22, 2025
Merged via the queue into onflow:master with commit ff8c3a9 Jan 22, 2025
56 checks passed
@peterargue peterargue deleted the AndriiDiachuk/6837-hearbeat-interval-correct-reset branch January 22, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Heartbeat interval not reset correctly in streaming endpoints
4 participants