Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Backport tx error messages PRs to v0.37 branch #6866

Open
wants to merge 59 commits into
base: v0.37
Choose a base branch
from

Conversation

AndriiDiachuk
Copy link
Contributor

@AndriiDiachuk AndriiDiachuk commented Jan 10, 2025

Backport of the PRs: #6468 #6525 #6497 .

Closes: #6614.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 55.23633% with 483 lines in your changes missing coverage. Please review.

Project coverage is 41.57%. Comparing base (bdb7b5e) to head (3ce30d5).
Report is 5 commits behind head on v0.37.

Files with missing lines Patch % Lines
cmd/access/node_builder/access_node_builder.go 0.00% 121 Missing ⚠️
storage/mock/transaction_result_error_messages.go 0.00% 105 Missing ⚠️
...e/common/rpc/execution_node_identities_provider.go 69.69% 40 Missing and 10 partials ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 48 Missing ⚠️
...min/commands/storage/backfill_tx_error_messages.go 74.07% 23 Missing and 12 partials ⚠️
...torage/badger/transaction_result_error_messages.go 77.44% 20 Missing and 10 partials ⚠️
storage/badger/operation/transaction_results.go 0.00% 25 Missing ⚠️
engine/access/ingestion/engine.go 33.33% 23 Missing and 1 partial ⚠️
...tion/tx_error_messages/tx_error_messages_engine.go 79.51% 14 Missing and 3 partials ⚠️
...estion/tx_error_messages/tx_error_messages_core.go 87.03% 5 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6866      +/-   ##
==========================================
+ Coverage   41.53%   41.57%   +0.04%     
==========================================
  Files        2032     2039       +7     
  Lines      181510   182223     +713     
==========================================
+ Hits        75382    75754     +372     
- Misses      99897   100209     +312     
- Partials     6231     6260      +29     
Flag Coverage Δ
unittests 41.57% <55.23%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndriiDiachuk AndriiDiachuk marked this pull request as ready for review January 14, 2025 14:36
@Guitarheroua Guitarheroua self-requested a review January 22, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants