Validate consistency of chunk Start and End states #6871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receipt validator checks that `chunk[i].EndState == chunk[i+1].StartState`
Modify ChunkListFixture to have consistent chunk start and end states. Previously, chunk start and end states were assigned independently, resulting in invalid execution receipts being used in tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6871 +/- ##
==========================================
- Coverage 41.18% 41.17% -0.01%
==========================================
Files 2109 2109
Lines 185660 185665 +5
==========================================
- Hits 76468 76452 -16
- Misses 102779 102801 +22
+ Partials 6413 6412 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the receipt validator (consensus node) verifies that each chunk's end state is the same as the next chunk's start state.
The requirement that the first chunk's starting state matches the end state from the previous execution result is already checked in
resultChainCheck.Issue: https://github.com/onflow/flow-go-internal/issues/5491