Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage Refactor] Refactor ConsumerProgress #6872

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

zhangchiqing
Copy link
Member

This PR refactors consumer progress to use badger batch updates instead of transactions.

Also created a ConsumerProgressInitializer to separate the initialization process.

@zhangchiqing zhangchiqing changed the base branch from master to leo/db-ops-dbstore January 10, 2025 22:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 15.94203% with 174 lines in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (0173d1d) to head (a16ce53).

Files with missing lines Patch % Lines
storage/mock/batch.go 0.00% 46 Missing ⚠️
storage/mock/db.go 0.00% 44 Missing ⚠️
storage/mock/consumer_progress_initializer.go 0.00% 28 Missing ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 22 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 12 Missing ⚠️
storage/store/consumer_progress.go 78.57% 6 Missing and 3 partials ⚠️
cmd/verification_builder.go 0.00% 7 Missing ⚠️
storage/operation/consume_progress.go 0.00% 4 Missing ⚠️
engine/testutil/nodes.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           leo/db-ops-dbstore    #6872      +/-   ##
======================================================
+ Coverage               41.17%   41.24%   +0.07%     
======================================================
  Files                    2111     1633     -478     
  Lines                  185733   147652   -38081     
======================================================
- Hits                    76477    60903   -15574     
+ Misses                 102844    81663   -21181     
+ Partials                 6412     5086    -1326     
Flag Coverage Δ
unittests 41.24% <15.94%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing changed the base branch from leo/db-ops-dbstore to master January 11, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants