Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get execution version from snapshot instead of state - v0.37 port #6883

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

janezpodhostnik
Copy link
Contributor

port of #6867

move snapshot provider

move snapshot state provider

cleanup
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 30.47210% with 162 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (bbb02eb) to head (ca6d246).

Files with missing lines Patch % Lines
state/protocol/mock/snapshot_execution_subset.go 0.00% 50 Missing ⚠️
fvm/environment/mock/get_version_beacon_func.go 0.00% 28 Missing ⚠️
fvm/environment/mock/execution_version_provider.go 0.00% 27 Missing ⚠️
...rotocol/mock/snapshot_execution_subset_provider.go 0.00% 19 Missing ⚠️
fvm/context.go 33.33% 10 Missing ⚠️
fvm/environment/minimum_required_version.go 66.66% 6 Missing and 3 partials ⚠️
engine/execution/testutil/fixtures.go 76.00% 4 Missing and 2 partials ⚠️
fvm/errors/execution.go 0.00% 5 Missing ⚠️
engine/execution/computation/snapshot_provider.go 0.00% 4 Missing ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6883      +/-   ##
==========================================
- Coverage   41.52%   41.48%   -0.04%     
==========================================
  Files        2032     2035       +3     
  Lines      181519   181590      +71     
==========================================
- Hits        75371    75333      -38     
- Misses      99912   100019     +107     
- Partials     6236     6238       +2     
Flag Coverage Δ
unittests 41.48% <30.47%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1010001 j1010001 requested a deployment to Production Docker Registry January 14, 2025 17:35 — with GitHub Actions Waiting
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just that I have the same suggestion as in the comments of this ported PR here #6867.

@janezpodhostnik janezpodhostnik merged commit a270553 into v0.37 Jan 16, 2025
55 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/v0.37-execution-version-from-snapshot branch January 16, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants