Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EVMBridgedMetadata view implementation #214

Merged
merged 6 commits into from
May 2, 2024

Conversation

sisyphusSmiling
Copy link
Collaborator

@sisyphusSmiling sisyphusSmiling commented Apr 29, 2024

Related: #213

Description

Adds implementation of EVMBridgedMetadata for both contract and token-level metadata.

Note: go tests pass, but I'm not able to get MetadataViews to update in the Cadence test suite to test against. I believe this is because the contract is included in those deployed to the test environment's service account and I'm not able to run an update on service account contracts in the current release version of Flow CLI. This feature is enabled in current pre-release versions of CLI and should be possible for the v2 branch until the MetadataViews contract is updated in the test suite's auto-deployed contracts.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels
  • Update the version in package.json when there is a change in the smart contracts

@sisyphusSmiling sisyphusSmiling self-assigned this Apr 29, 2024
@sisyphusSmiling sisyphusSmiling added SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board enhancement New feature or request labels Apr 29, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 29, 2024 21:14
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you want the cadence tests to pass, you can just deploy a new version of the MetadataViews contract and test against that. that is what we do in all the Go tests and in the Cadence 1.0 Cadence tests

@sisyphusSmiling
Copy link
Collaborator Author

Thanks for the tip @joshuahannan! I did exactly that and made relevant changes to test coverage and looks like CI is passing now

@sisyphusSmiling sisyphusSmiling merged commit d8db9b2 into master May 2, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the giovanni/add-evm-metadata-impl branch May 2, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants