Merge FLIP Fest PRs #195
Merge FLIP Fest PRs #195
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onflow/flow-playground/7QEXJuWNbBhYEZ9pC99qJMDNPcdM |
|
@10thfloor can you tell what was the problem with our tutorials so I can check if this was fixed? |
There was a problem hiding this comment.
Looks good @MaxStalker!
I have a comment about the URL structure, but don't let it block this PR.
| navigate(`/${this.projectId}`, { replace: true}); | ||
|
|
||
| navigate(`/${this.projectId}?type=readme&id=0`, { replace: true }); |
There was a problem hiding this comment.
I think the README should just be the default view when loading a project. Is ?type=readme required?
src/util/url.ts
Outdated
| @@ -11,6 +11,6 @@ export const getParams = (url: string): any => { | |||
| },{}) | |||
| } | |||
|
|
|||
| export const scriptTypes = ["account", "tx", "script"] | |||
| export const scriptTypes = ["account", "tx", "script", "readme"] | |||
There was a problem hiding this comment.
Should this be pageTypes instead of scripts?
This PR shall resolve all merge conflicts and bring Playground back into stable form.