Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageServer and Bool Arguments Fixes #201

Merged
merged 4 commits into from
Jan 20, 2022
Merged

LanguageServer and Bool Arguments Fixes #201

merged 4 commits into from
Jan 20, 2022

Conversation

MaxStalker
Copy link
Contributor

@MaxStalker MaxStalker commented Jan 20, 2022 •
edited
Loading

Closes: #194 and #198

Description

CadenceEditor is still being render, but hidden with display: none CSS.
Fixes the error without big refactoring, which potentially can introduce new bugs and issues.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker requested a review from 10thfloor as a code owner January 20, 2022 18:14
@vercel
Copy link

vercel bot commented Jan 20, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-playground/FnMQEfk2Uj3UjkakniHZ9yHb3UCA
✅ Preview: https://flow-playground-git-max-198-language-server-fix-onflow.vercel.app

@MaxStalker MaxStalker requested a review from psiemens January 20, 2022 18:14
@MaxStalker MaxStalker closed this Jan 20, 2022
@MaxStalker MaxStalker force-pushed the max/198-language-server-fix branch from 331c85e to a1d47f2 Compare January 20, 2022 18:27
@vercel vercel bot temporarily deployed to Preview January 20, 2022 18:27 Inactive
@MaxStalker MaxStalker reopened this Jan 20, 2022
@vercel vercel bot temporarily deployed to Preview January 20, 2022 18:29 Inactive
@vercel vercel bot temporarily deployed to Preview January 20, 2022 19:06 Inactive
@MaxStalker MaxStalker changed the title LanguageServer Fix LanguageServer and Bool Arguments Fixes Jan 20, 2022
10thfloor
10thfloor suggested changes Jan 20, 2022
View reviewed changes
src/containers/Editor/components.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 20, 2022 19:13 Inactive
@10thfloor 10thfloor merged commit acd3b17 into master Jan 20, 2022
This was referenced Jan 20, 2022
Closed
Closed
@10thfloor 10thfloor mentioned this pull request Jan 21, 2022
Closed
@bthaile bthaile deleted the max/198-language-server-fix branch May 16, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10thfloor 10thfloor 10thfloor requested changes

@psiemens psiemens Awaiting requested review from psiemens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to pass Bool argument
2 participants
@MaxStalker @10thfloor