Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crypto polyfill #627

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fix crypto polyfill #627

merged 2 commits into from
Jun 6, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jun 6, 2024

Closes #626

Description

Fixes crypto polyfill broken by v1.90.0

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Bugfix label Jun 6, 2024
@jribbink jribbink merged commit 9c8f010 into master Jun 6, 2024
5 of 6 checks passed
@jribbink jribbink deleted the jribbink/crypto-fix branch June 6, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

@nialexsan nialexsan Awaiting requested review from nialexsan

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cadence plugin failed to be activated in the latest VSCode
2 participants
@jribbink @chasefleming