[sc-15142] Rubicon InApp: Add Blocklists attribute for App #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abyfall
reviewed
Jan 14, 2025
Comment on lines
+149
to
+156
| // Attribute: | ||
| // blocklists | ||
| // Type: | ||
| // string array | ||
| // Description: | ||
| // Array of blocklist use for Rubicon | ||
| Blocklists []string `json:"blocklists,omitempty"` | ||
|
|
There was a problem hiding this comment.
Do you know why they didn't use the Ext field ? Seems misleading to add an exchange specific attribute at this level
There was a problem hiding this comment.
Unfortunately I don't know but I think it may be a legacy field because the app.blocklists becomes app.ext.rp.blocklists when using protobuf.
Source: https://help.magnite.com/help/xapi-protobuf-integrations#xapi-field-changes
There was a problem hiding this comment.
Maybe we could ask them to support it inside the ext.
Abyfall
approved these changes
Jan 14, 2025
Clement3
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding blocklists attribute for Rubicon in App object.
Link to their doc