Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for es7 in version 5 #909

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Add support for es7 in version 5 #909

merged 4 commits into from
Feb 5, 2020

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Feb 2, 2020

This change would allow to install the ES7 client and use it with the same api. It would help us that the community can use the newest ES version when using the SuluArticleBundle. Upgrading to the newest version of the bundle would be in our case to many bc breaks at current state.

The change itself is simple if its uses Elasticsearch 7 the Index settings is set to:

include_type_name=true

@saimaz saimaz merged commit f42ae00 into ongr-io:5.2 Feb 5, 2020
@alexander-schranz alexander-schranz deleted the feature/support-es7-in-version-5 branch February 6, 2020 00:29
@fredericbarthelet
Copy link

@alexander-schranz just noticed that I had to require ocramius/package-version in my project in order to ensure this package can retrieve elasticsearch-dsl version. Shouldn't this package be required in this project instead ?

@alexander-schranz
Copy link
Contributor Author

@fredericbarthelet don't wanted to break someones project by adding a additional package, but if @saimaz is ok for it we could add ocramius/package-versions:^1.0 as requirement.

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Jun 30, 2020

@fredericbarthelet we decided to add Symfony 5 support to the v5 version to fork this bundle. There the requirement for the ocramius/package-version is removed and is instead build on top of a VERSION constant by added php elasticsearch library.

The fork can be found here: https://github.com/handcraftedinthealps/elasticsearchbundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants