feat: do not rerender tab on navigate #26
Conversation
Conflicts: Sources/TabBar/View/TabBar.swift
Conflicts: Sources/TabBar/View/TabBar.swift
There was a problem hiding this comment.
Hello and thanks for your PR!
I have indicated some small issues that should be fixed before we move forward with the merge. Also, if the thing with ignoring keyboard area is not connected with the issue #7, it should be moved into separate PR.
| @@ -5,7 +5,7 @@ import PackageDescription | |||
| let package = Package( | |||
| name: "TabBar", | |||
| platforms: [ | |||
| .iOS(.v13) | |||
| .iOS("14") | |||
There was a problem hiding this comment.
It is better to use .v14 value here
| content | ||
| .opacity(self.item == self.selectionObject.selection ? 1 : 0) |
There was a problem hiding this comment.
Please correct indentation of opacity modifier
| ZStack { | ||
| self.content | ||
| .environmentObject(self.selectedItem) | ||
| .padding(.bottom, 50) |
There was a problem hiding this comment.
Could you please clarify why we need this padding here, and what does value of 50 points mean?
There was a problem hiding this comment.
Child view of TabBar collides with TabBar without this. 50 is the DefaultTabBarStyle tabbar height. Bottom 50px of view is not visible without this padding.
| self.items = value | ||
| } | ||
| } | ||
| .ignoresSafeArea(.keyboard) |
There was a problem hiding this comment.
Could you explain why we need this here?
There was a problem hiding this comment.
If you use a keyboard inside a child view of tabbar. The tabbar moves up with keyboard without this modifier. This is the reason I increased iOS version from 13 to 14.
|
Ignoring keyboard codes are not related. Sorry for that, I will seperate. |
by using opacity, instead of if; tabs view state stays on changing to another tab. If you have a scroll view and user scrolled, switching tab and returning back preserves scroll view state. Tab view do not reinit.