Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resize limitations in TensorRT #538

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Update resize limitations in TensorRT #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 46 additions & 9 deletions builtin_op_importers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2536,9 +2536,11 @@ DEFINE_BUILTIN_OP_IMPORTER(Resize)
{
nvinfer1::ITensor& input = convertToTensor(inputs.at(0), ctx);
// TRT does not support INT32 nor BOOL input types for this node
ASSERT(input.getType() != nvinfer1::DataType::kINT32 && input.getType() != nvinfer1::DataType::kBOOL, ErrorCode::kUNSUPPORTED_NODE);
ASSERT( (input.getType() != nvinfer1::DataType::kINT32
&& input.getType() != nvinfer1::DataType::kBOOL)
&& "This version of TensorRT does not support INT32 or BOOL input for the Resize operator.", ErrorCode::kUNSUPPORTED_NODE);
int inputRank = input.getDimensions().nbDims;
ASSERT(inputRank > 0, ErrorCode::kUNSUPPORTED_NODE);
ASSERT( (inputRank > 0) && "The input tensor cannot be a scalar.", ErrorCode::kUNSUPPORTED_NODE);
// Add resize layer
nvinfer1::IResizeLayer* layer = ctx->network()->addResize(input);
ctx->registerLayer(layer, node.name());
Expand All @@ -2563,22 +2565,57 @@ DEFINE_BUILTIN_OP_IMPORTER(Resize)
&& "This version of TensorRT only supports floor nearest_mode!",
ErrorCode::kUNSUPPORTED_NODE);

// Note both asymmetric and align_corners resize modes go through the same import path in TRT:
if (transformationMode == "asymmetric" || transformationMode == "align_corners")
{
layer->setAlignCorners(true);
}

// The existence of a fourth input means a shape was passed as the resize parameter
// For ONNX resize with the "sizes", TensorRT's resize maps to ONNX's in the following ways:
// Nearest:
// alignCorners = 0: ASYMMETRIC
// alignCorners = 1: ALIGN_CORNERS
// Linear:
// alignCorners = 0: HALF_PIXEL
// alignCorners = 1: ALIGN_CORNERS
if (inputs.size() == 4)
{
if (transformationMode == "align_corners")
{
layer->setAlignCorners(true);
}
if (mode == "nearest")
{
ASSERT((transformationMode == "asymmetric" || transformationMode == "align_corners") && "TensorRT only supports asymmetric and align_corners transformation modes for nearest neighbor resizes when sizes are provided!", ErrorCode::kUNSUPPORTED_NODE);
}
else if (mode == "linear")
{
ASSERT((transformationMode == "half_pixel" || transformationMode == "pytorch_half_pixel" || transformationMode == "align_corners") && "TensorRT only supports half_pixel, pytorch_half_pixel, and align_corners transofmration modes for linear resizes when sizes are provided!", ErrorCode::kUNSUPPORTED_NODE);
}
auto* resizeShape = &convertToTensor(inputs.at(3), ctx);
layer->setInput(1, *resizeShape);
layer->setResizeMode(resizeMode);
RETURN_FIRST_OUTPUT(layer);
}
// For ONNX resize with "scales", TensorRT's resize maps to ONNX's in the following ways:
// Nearest:
// alignCorners = 0: ASYMMETRIC
// alignCorners = 1: ASYMMETRIC
// Linear:
// alignCorners = 0: HALF_PIXEL
// alignCorners = 1: ASYMMETRIC
else
{
if (mode == "nearest")
{
ASSERT(transformationMode == "asymmetric" && "TensorRT only supports asymmetric tranformation mode for nearest neighbor resizes when scales are provided!",ErrorCode::kUNSUPPORTED_NODE);
}
else if (mode == "linear")
{
ASSERT((transformationMode == "asymmetric" || transformationMode == "pytorch_half_pixel" || transformationMode == "half_pixel") && "TensorRT only supports half pixel, pytorch half_pixel, and asymmetric tranformation mode for linear resizes when scales are provided!", ErrorCode::kUNSUPPORTED_NODE);
if (transformationMode == "asymmetric")
{
layer->setAlignCorners(true);
}
}
}
}
// For opset 10 resize, the only supported mode is asymmetric resize, which is mapped to TRT's alignCorners.
// For opset 10 resize, the only supported mode is asymmetric resize with scales.
else
{
transformationMode = "asymmetric";
Expand Down