Fix: Window functions generate incorrect shape for with symmetric attribute #4256
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheil Kumar <[email protected]>
Signed-off-by: Sheil Kumar <[email protected]>
Signed-off-by: Sheil Kumar <[email protected]>
Signed-off-by: Sheil Kumar <[email protected]>
Signed-off-by: Sheil Kumar <[email protected]>
gramalingam
approved these changes
Jun 8, 2022
|
@etiotto please cherry pick |
liqunfu
pushed a commit
that referenced
this pull request
Jun 9, 2022
…ribute (#4256) * fix symmetric function definition, and add shape inference test Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * flake8 whitespace error Signed-off-by: Sheil Kumar <[email protected]> * fix stft test Signed-off-by: Sheil Kumar <[email protected]>
liqunfu
pushed a commit
that referenced
this pull request
Jun 9, 2022
…ribute (#4256) * fix symmetric function definition, and add shape inference test Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * flake8 whitespace error Signed-off-by: Sheil Kumar <[email protected]> * fix stft test Signed-off-by: Sheil Kumar <[email protected]> Signed-off-by: Liqun Fu <[email protected]>
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Jun 10, 2022
…ribute (onnx#4256) * fix symmetric function definition, and add shape inference test Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * flake8 whitespace error Signed-off-by: Sheil Kumar <[email protected]> * fix stft test Signed-off-by: Sheil Kumar <[email protected]> Signed-off-by: Chun-Wei Chen <[email protected]>
jcwchen
added a commit
that referenced
this pull request
Jun 10, 2022
* Use op name rather than hard-coding Hann in window op doc strings. (#4248) And strip trailing spaces. Signed-off-by: Gary Miguel <[email protected]> Signed-off-by: Chun-Wei Chen <[email protected]> * Fix: Window functions generate incorrect shape for with symmetric attribute (#4256) * fix symmetric function definition, and add shape inference test Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * flake8 whitespace error Signed-off-by: Sheil Kumar <[email protected]> * fix stft test Signed-off-by: Sheil Kumar <[email protected]> Signed-off-by: Chun-Wei Chen <[email protected]> * support truncation & fix big-endian support (#4238) Signed-off-by: Ian Bearman <[email protected]> Signed-off-by: Chun-Wei Chen <[email protected]> * Fix layer normalization's reference outputs (#4263) Signed-off-by: Chun-Wei Chen <[email protected]> * handle raw types correctly in helper.make_tensor (#4262) Signed-off-by: Chun-Wei Chen <[email protected]> * bump to 1.12.0rc4 for cherry-picks Signed-off-by: Chun-Wei Chen <[email protected]> * Fix sub-graph generation for LN (#4268) Signed-off-by: Wei-Sheng Chin <[email protected]> Signed-off-by: Chun-Wei Chen <[email protected]> Co-authored-by: Gary Miguel <[email protected]> Co-authored-by: Sheil Kumar <[email protected]> Co-authored-by: Ian Bearman <[email protected]> Co-authored-by: Wei-Sheng Chin <[email protected]>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
…ribute (onnx#4256) * fix symmetric function definition, and add shape inference test Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * whitespace... Signed-off-by: Sheil Kumar <[email protected]> * flake8 whitespace error Signed-off-by: Sheil Kumar <[email protected]> * fix stft test Signed-off-by: Sheil Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Window functions generate incorrect shape for with symmetric attribute
Affects: hannwindow, hammingwindow, and blackmanwindow operators.
Issue: The periodic=0 option to create a symmetric window for these operators was incorrectly causing the size of the output to be reduced by 1 in the function definition.
Test added to verify output shape with periodic attribute set to 0.
STFT test slicing expected output incorrectly. This causes the DFT to be run on a different size, as opposed to be being run on the original size, and sliced after.