Skip version conversion if non-ONNX domain and throw explicit error #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <[email protected]>
jcwchen
added
the
module: version converter
Signed-off-by: Chun-Wei Chen <[email protected]>
xadupre
reviewed
Sep 19, 2022
| continue; | ||
| } | ||
| if (op_name != "Undefined" && op_name != "Captured") { | ||
| } else if (cur_op->domain() != "" && cur_op->domain() != "ai.onnx") { |
There was a problem hiding this comment.
What if a node is Undefined from a domain != from "" or "ai.onnx"?
There was a problem hiding this comment.
Good question. Did you mean an operator named "Undefined" but from domain "" or "ai.onnx"? If yes, current behavior is do nothing without any error message.
xadupre
approved these changes
Sep 20, 2022
liqunfu
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip version conversion if non-ONNX domain and throw explicit error.
Motivation and Context
Fixes #4515.