-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the blob failed model tests #1806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hwangdeyu <[email protected]>
hwangdeyu
force-pushed
the
skip_failedblob_test
branch
from
December 20, 2021 10:14
d60d521
to
ec8b14c
Compare
fatcat-z
reviewed
Dec 20, 2021
@@ -21,9 +21,20 @@ | |||
if os.environ.get('ENABLE_FULL_TRANSFORMER_TEST', '0') != '0': | |||
enable_transformer_test = True | |||
|
|||
def check_bloburl_access(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add a common.py to save such common methods and avoid having duplicated ones in different tests files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
fatcat-z
reviewed
Dec 20, 2021
tests/keras2onnx_applications/nightly_build/test_transformers.py
Outdated
Show resolved
Hide resolved
hwangdeyu
force-pushed
the
skip_failedblob_test
branch
3 times, most recently
from
December 20, 2021 12:16
0039253
to
ec7f29c
Compare
fatcat-z
approved these changes
Dec 20, 2021
hwangdeyu
force-pushed
the
skip_failedblob_test
branch
from
December 20, 2021 15:40
ec7f29c
to
45247dd
Compare
Signed-off-by: hwangdeyu <[email protected]>
hwangdeyu
force-pushed
the
skip_failedblob_test
branch
3 times, most recently
from
December 21, 2021 14:21
92f8e90
to
0223bc9
Compare
Signed-off-by: hwangdeyu <[email protected]>
hwangdeyu
force-pushed
the
skip_failedblob_test
branch
from
December 21, 2021 14:26
0223bc9
to
eb3216f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hwangdeyu [email protected]
Co-authored-by: fatcat-z [email protected]