Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the blob failed model tests #1806

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Conversation

hwangdeyu
Copy link
Contributor

@hwangdeyu hwangdeyu commented Dec 20, 2021

Signed-off-by: hwangdeyu [email protected]
Co-authored-by: fatcat-z [email protected]

@hwangdeyu hwangdeyu requested a review from fatcat-z December 20, 2021 10:14
@hwangdeyu hwangdeyu force-pushed the skip_failedblob_test branch from d60d521 to ec8b14c Compare December 20, 2021 10:14
@@ -21,9 +21,20 @@
if os.environ.get('ENABLE_FULL_TRANSFORMER_TEST', '0') != '0':
enable_transformer_test = True

def check_bloburl_access():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add a common.py to save such common methods and avoid having duplicated ones in different tests files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@hwangdeyu hwangdeyu force-pushed the skip_failedblob_test branch 3 times, most recently from 0039253 to ec7f29c Compare December 20, 2021 12:16
@hwangdeyu hwangdeyu force-pushed the skip_failedblob_test branch from ec7f29c to 45247dd Compare December 20, 2021 15:40
@hwangdeyu hwangdeyu force-pushed the skip_failedblob_test branch 3 times, most recently from 92f8e90 to 0223bc9 Compare December 21, 2021 14:21
Signed-off-by: hwangdeyu <[email protected]>
@hwangdeyu hwangdeyu force-pushed the skip_failedblob_test branch from 0223bc9 to eb3216f Compare December 21, 2021 14:26
@hwangdeyu hwangdeyu merged commit 6691850 into onnx:master Dec 21, 2021
@hwangdeyu hwangdeyu deleted the skip_failedblob_test branch December 21, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants