feat: update NCS 2.9.0 support #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stig-bjorlykke
commented
Feb 5, 2025
stig-bjorlykke
commented
- Move CONFIG_SOFTSIM_BUNDLE_TEMPLATE_HEX to sysbuild.
- Fix compiler warnings when printing eDRX parameters.
MirkoCovizzi
reviewed
Feb 5, 2025
| @@ -143,7 +143,7 @@ west build -b nrf9151dk/nrf9151/ns -- "-DOVERLAY_CONFIG=$PATH_TO_ONOMONDO_SOFTSI | |||
| Where `PATH_TO_ONOMONDO_SOFTSIM` is the path of the downloaded Onomondo SoftSIM repository, for example `$HOME/ncs/nrf-softsim-dev`. | |||
|
|
|||
| #### Note | |||
| SoftSIM is relying on some default data in the storage partition. This section of the flash can be generated and flashed manually (see steps below) or, as we recommend, automatically included by `CONFIG_SOFTSIM_BUNDLE_TEMPLATE_HEX=y` | |||
| SoftSIM is relying on some default data in the storage partition. This section of the flash can be generated and flashed manually (see steps below) or, as we recommend, automatically included by `SB_CONFIG_SOFTSIM_BUNDLE_TEMPLATE_HEX=y` | |||
There was a problem hiding this comment.
Maybe a note about sysbuild Kconfigs, or tell the reader that this specific Kconfig option must be added to sysbuild.conf?
* Move CONFIG_SOFTSIM_BUNDLE_TEMPLATE_HEX to sysbuild. * Fix compiler warnings when printing eDRX parameters. Signed-off-by: Stig Bjørlykke <[email protected]>
stig-bjorlykke
force-pushed
the
feat/updates-for-ncs-2.9.0
branch
from
31d1404 to
bac81b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.