Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias model#new_record? to #new? #4

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Alias model#new_record? to #new? #4

merged 1 commit into from
Mar 22, 2018

Conversation

phyrog
Copy link

@phyrog phyrog commented Mar 21, 2018

This fixes a bug with Devise 4.4.2 and upwards, which now expects the User model to have a new_record? method, see https://github.com/plataformatec/devise/blob/d870c0dced8499931495e07190aa8a9ff8caaadf/lib/devise/models/trackable.rb#L34-L37

@phyrog phyrog requested a review from eugenk March 21, 2018 15:32
@phyrog phyrog changed the title Alias model#new_record? to #new Alias model#new_record? to #new? Mar 21, 2018
Copy link
Member

@eugenk eugenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This answers my question in ontohub/ontohub-backend#407 (comment)

@phyrog phyrog merged commit 194e7bf into master Mar 22, 2018
@phyrog phyrog deleted the fix_for_devise_4.4.2 branch March 22, 2018 10:55
@phyrog
Copy link
Author

phyrog commented Mar 23, 2018

@eugenk could you do a new release in the next couple of days for this?

@eugenk
Copy link
Member

eugenk commented Mar 24, 2018

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants