Feature: Update account page design #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
requested changes
Feb 24, 2023
app/views/users/show.html.haml
Outdated
| %h4.account-page-card-title Personal information | ||
| %a.account-page-rounded-button{:href => edit_user_path(url_encode(@user.username))} | ||
| / SVG: Edit icon | ||
| %svg{fill: "none", height: "18", viewbox: "0 0 18 18", width: "18", xmlns: "http://www.w3.org/2000/svg"} |
There was a problem hiding this comment.
extract SVG in files, it make it hard to read the file
|
Some bugs found subscribe button to aligned
mailing list incorrect subject and body
Orcid validation
Click on grant admin permission shows the following
|
|
Okay 👌 |
syphax-bouazzouni
requested changes
Feb 27, 2023
app/assets/stylesheets/account.scss
Outdated
| @@ -0,0 +1,188 @@ | |||
| a{ | |||
There was a problem hiding this comment.
this will change the link everywhere not only in the account page
| %div{style:"margin-top:12px"} | ||
| %div | ||
| %button.btn.btn-primary{id: "subscribe"} | ||
| %a.account-page-subscribe-button{:href => 'mailto:... &subject=... &body=....'} |
There was a problem hiding this comment.
put the correct subject and body
|
I've fixed all the problems except for the subscription mail, can you please give me the subject & body to put, or should I think about writing it by myself? |
syphax-bouazzouni
approved these changes
Mar 1, 2023
|
Merged, @Bilelkihal add the correct Subscription mail subject and body in another PR. |
34 tasks
syphax-bouazzouni
pushed a commit
that referenced
this pull request
Apr 17, 2024
Bump tzinfo from 1.2.9 to 1.2.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The old interface has bad styling and does not provide a good user experience.
What I did
Screenshots
Old
New