Fix: Ontology description text display when it is a complex object not a string #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
changed the title
|
A small remark on the PR title naming, I changed it
Same for your commit name: fix bug display of definitions in ANAEETHES ontology (094fd93) It is not ANAEETHES ontology-specific bug, and does explain what (or why) the commit does; I would prefer something like this: |
syphax-bouazzouni
requested changes
Jun 14, 2023
| @@ -29,7 +29,11 @@ | |||
| %tr | |||
| %td{nowrap: ""} Definitions | |||
| %td | |||
| %p= @concept.definition.join(" ") | |||
| - @concept.definition.each do |definition| | |||
There was a problem hiding this comment.
extract it into a helper (in ontologies_helper on concepts_helpers)
syphax-bouazzouni
approved these changes
Jun 15, 2023
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 5, 2023
Fix: Ontology description text display when it is a complex object not a string
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 6, 2023
… and Bug fixes (#335) * Merge pull request #281 from ontoportal-lirmm/fix-bug-in-slices-links fix bug in slices links * Merge pull request #212 from ontoportal-lirmm/fix/signup-fields-validation Fix: Signup page input fields validation * Merge pull request #214 from ontoportal-lirmm/feature/update-account-page-design Feature: Update submited ontologies and created projet sections design * Merge pull request #237 from ontoportal-lirmm/feature/ecoportal/groups-categories-administration Feature: Add categories and groups administration * Merge pull request #273 from ontoportal-lirmm/fix/bug-ANAEETHES-ontology Fix: Ontology description text display when it is a complex object not a string * Merge pull request #277 from ontoportal-lirmm/Fix-alphabetical-sorting Fix: Alphabetical sorting in the the collection members display * Fix: bug of display list submitted ontologies of account setting (#286) * fix display list of views of ontologies in Submitted ontologies #270 * fix bug of display text in alert when there is no collections (#285) fix the alert message text that is wrapping and overflowing out #266 * Merge pull request #287 from ontoportal-lirmm/fix-bug-reset-password Fix: bug of reset password * Fix bug of select list view of ontology (#289) * Add Chosen.js functionality to fix bug of select views of ontolgy * Add Chosen.js functionality for list views ontologies * fix bug of update ontology where there is no view * Refactor code * Delete ponse = @ontology.update * Merge pull request #295 from ontoportal-lirmm/Fix-display-the-list-of-concepts-in-a-collection-at-one-sight Fix: display the list of concepts in a collection at one sight * Merge pull request #291 from ontoportal-lirmm/Fix-remove-views-of-submitted-ontologies-in-account-setting Fix: Remove views ontologies in list of submitted ontologies * Merge pull request #280 from ontoportal-lirmm/Fix-Ontology-style-text-display-when-it-is-uri Fix: ontology style text display when it is uri * Merge pull request #254 from ontoportal-lirmm/feature/add-ontology-count-to-group-and-category Feature: add column ontologies count to categories and-groups admin page * Merge pull request #302 from ontoportal-lirmm/feature/migrate-fair-score-js-code Feature: Migrate fair score JS code to Stimulus controllers * fix generated bug after edit group and category (#334) --------- Co-authored-by: SirineMhedhbi <[email protected]>
syphax-bouazzouni
pushed a commit
that referenced
this pull request
Feb 29, 2024
Advance Rails to 6.1.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See agroportal/project-management#425
Changes