Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Summary pages issues #395

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Dec 5, 2023

This is the list of issues fixed in this PR:

  • Replace "Initial release occurred on" by "Initial created on" in general bloc.
    need in pull request of summary 01

  • Restrict license badge text break on ontology header
    image

  • Add "contact support" button in ontology details alert
    image

  • Change "last uploaded" by "last submission date" in ontology header
    image

  • In other links block, replace "Free-text search endpoint" by an icon

  • In other links block show only: included, is ofrmat of and has format

@Bilelkihal Bilelkihal added the bug Something isn't working label Dec 5, 2023
@Bilelkihal Bilelkihal self-assigned this Dec 5, 2023
@Bilelkihal Bilelkihal marked this pull request as draft December 5, 2023 09:02
@@ -82,3 +82,8 @@
}


.alert-button{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the button component, instead of adding a new CSS

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually using the button component, and this is just a container to style the button inside the alert

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, I see.
but maybe the name could be , for example alert-action-button

app/assets/stylesheets/summary.scss.erb Outdated Show resolved Hide resolved
@@ -82,3 +82,8 @@
}


.alert-button{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually using the button component, and this is just a container to style the button inside the alert

app/helpers/ontologies_helper.rb Show resolved Hide resolved
app/assets/stylesheets/summary.scss.erb Outdated Show resolved Hide resolved
@@ -82,3 +82,8 @@
}


.alert-button{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, I see.
but maybe the name could be , for example alert-action-button

@syphax-bouazzouni syphax-bouazzouni marked this pull request as ready for review December 7, 2023 23:46
@syphax-bouazzouni
Copy link
Collaborator

I added the three remaining tasks:

  • update metadata_vocabulary_display helper to show only the prefix (39de4dd)
    image

  • update other links bloc in the summary page to remove not needed properties (99bcb88)

  • add in summary page search icon that redirects to API search endpoint (fa90818)

  • fix submission edit system test after the metadataVoc update (e1d6a5f)
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants