Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update concept mappings table style #574

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Feature: Update concept mappings table style #574

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e1ce61
fix search page search button style
Bilelkihal Apr 11, 2024
5cd1e61
fix search page json button style
Bilelkihal Apr 11, 2024
0f8af5d
update concepts mappings table style
Bilelkihal Apr 11, 2024
fee6825
add back chip button overflow wraping in concepts mappings table
Bilelkihal Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/assets/stylesheets/mappings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,7 @@ div#map_from_concept_details_table, div#map_to_concept_details_table {
#concept_mappings_table {
width: 100%;
}
#concept_mappings_table .chip_button_container_clickable{
white-space: nowrap;
Bilelkihal marked this conversation as resolved.
Show resolved Hide resolved
}

3 changes: 2 additions & 1 deletion app/assets/stylesheets/search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

.search-page-input{
position: relative;
padding-bottom: 80px;
padding-bottom: 30px;
display: flex;
.search-container{
top:65px;
}
Expand Down
2 changes: 1 addition & 1 deletion app/views/mappings/_mapping_table.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
= check_box_tag "delete_mappings_permission", @delete_mapping_permission, @delete_mapping_permission, style: "display: none;"
%div#concept_mappings_tables_div
= render_alerts_container(MappingsController)
%table#concept_mappings_table.zebra{width: "100%", style:'word-break: break-word'}
%table#concept_mappings_table.table-content-stripped.table-content{width: "100%", style:'word-break: break-word'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the Table component here, no just using its style.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of javascript code to be rewriten this is why I prefered to use only the style, the day we migrate the js code we can use the new component

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

%thead
%tr
%th= t("mappings.mapping_table.mapping_to")
Expand Down
2 changes: 1 addition & 1 deletion app/views/search/index.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
.search-page-number-of-results
= "#{t('search.match_in')} #{@search_results.length} #{t('search.ontologies')}"
%div.d-flex
.search-page-json.mx-4
.search-page-json.mx-4.mt-1
= search_json_link
.search-page-advanced-button.show-options{class: "#{@advanced_options_open ? 'd-none' : ''}",'data': {'action': 'click->reveal-component#show', 'reveal-component-target': 'showButton'}}
.icon
Expand Down
Loading