Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: disable eager loading in production and load the sections only if visited #912

Merged

Conversation

syphax-bouazzouni
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni commented Jan 10, 2025

Context

One a user go to the ontology viewer of an ontology, e.g https://stageportal.lirmm.fr/ontologies/AGROVOC, it loads the current visited page and in the background fetch th remaining sections.
It is good if our API could support that amount of calls, but unfortunately it does overload the server with calls that are even possibly not even seen by the end users (e.g mappings section)
Now the following section are loaded in the background summary, classes, properties,instances,collections,schemes
And the following will be loaded only in visit mappings, notes, widgets, sparql

Changes

  • Make the ontology viewer load the sections only if visited (6ab8354)
  • Update the ontology viewer to lazy the section that are not data (de18fbd)

@syphax-bouazzouni syphax-bouazzouni self-assigned this Jan 10, 2025
@syphax-bouazzouni syphax-bouazzouni added the enhancement New feature or request label Jan 10, 2025
@syphax-bouazzouni syphax-bouazzouni force-pushed the feauture/disable-eager-loiding-in-production branch from 6ab8354 to 12a62e8 Compare January 11, 2025 17:29
@syphax-bouazzouni syphax-bouazzouni changed the base branch from master to development January 13, 2025 12:43
@Bilelkihal
Copy link
Collaborator

Bilelkihal commented Jan 13, 2025

After deploying this to StagePortal, the UX is obviously worse.
I propose a compromise, we keep the eager loading only for classes/concepts and not for the other tabs.
@syphax-bouazzouni what do you think?

@syphax-bouazzouni syphax-bouazzouni changed the title Feauture: disable eager loading in production and load the sections only if visited Feature: disable eager loading in production and load the sections only if visited Jan 27, 2025
@Bilelkihal Bilelkihal merged commit a432234 into development Feb 4, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants