Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add federation tests #918

Merged
merged 14 commits into from
Feb 6, 2025
Merged

Feature: Add federation tests #918

merged 14 commits into from
Feb 6, 2025

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Jan 17, 2025 •
edited
Loading

Added system tests for the main use cases of federated search and federated browse pages.

Tests included in this PR:

Federated Search on the Search Page (4.48s)

  • Enable federation and verify that results are retrieved correctly from another portal.
  • Ensure duplicate results are handled properly.

Federated Browse (37.22s)

  • Enable federation and verify that results are retrieved correctly from another portal.
  • Ensure duplicate results are handled properly.

Federated Search When Portal is Down (3.10s)

Federated Browse When Portal is Down (5.09s)

@Bilelkihal Bilelkihal marked this pull request as draft January 17, 2025 12:48
@Bilelkihal Bilelkihal mentioned this pull request Jan 30, 2025
Merged
@Bilelkihal Bilelkihal marked this pull request as ready for review January 31, 2025 09:19
@Bilelkihal Bilelkihal self-assigned this Jan 31, 2025
Bilelkihal
Bilelkihal commented Jan 31, 2025
View reviewed changes
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

syphax-bouazzouni
syphax-bouazzouni requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work in the tests, they are quiet explicit and easy to read.

test/system/federation_test.rb Show resolved Hide resolved
syphax-bouazzouni
syphax-bouazzouni requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests is not passing for BIPOM, to fix before merging.

Gemfile Outdated Show resolved Hide resolved
config/bioportal_config_test.rb Outdated Show resolved Hide resolved
@syphax-bouazzouni syphax-bouazzouni merged commit b181450 into development Feb 6, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphax-bouazzouni syphax-bouazzouni syphax-bouazzouni approved these changes

Assignees

@Bilelkihal Bilelkihal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilelkihal @syphax-bouazzouni