Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Agent search not working well #107

Closed
wants to merge 1 commit into from

Conversation

Bilelkihal
Copy link
Collaborator

Related issue: ontoportal-lirmm/bioportal_web_ui#799

Changes

  • Add * to the search query of the endpoint /search/agents

@Bilelkihal Bilelkihal self-assigned this Nov 5, 2024
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want it at this level, put it in the UI.

@Bilelkihal
Copy link
Collaborator Author

we don't want it at this level, put it in the UI.

Why?
The api is responsible for giving correct results without the need of playing in the query by adding a star or something, what do you think?

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Nov 7, 2024

we don't want it at this level, put it in the UI.

Why? The api is responsible for giving correct results without the need of playing in the query by adding a star or something, what do you think?

@Bilelkihal, because the API is open, so by default it uses the default behavior of the indexer (full-text match), if the user wants to match text starting with a query he will do query*, if he wants to match term ending with a query he will do *query, and he can use any other regex pattern (start with, ends with, optional, ....), here is an example done by imad for the URI work https://github.com/ontoportal-lirmm/bioportal_web_ui/blob/master/app/controllers/concerns/uri_redirection.rb#L53

And other reason is just that the tests are not passing.

@Bilelkihal
Copy link
Collaborator Author

we don't want it at this level, put it in the UI.

Why? The api is responsible for giving correct results without the need of playing in the query by adding a star or something, what do you think?

@Bilelkihal, because the API is open, so by default it uses the default behavior of the indexer (full-text match), if the user wants to match text starting with a query he will do query*, if he wants to match term ending with a query he will do *query, and he can use any other regex pattern (start with, ends with, optional, ....), here is an example done by imad for the URI work https://github.com/ontoportal-lirmm/bioportal_web_ui/blob/master/app/controllers/concerns/uri_redirection.rb#L53

And other reason is just that the tests are not passing.

Okay I'll close this PR and do another one in the UI side

@Bilelkihal
Copy link
Collaborator Author

Done here: ontoportal-lirmm/bioportal_web_ui#837

@Bilelkihal Bilelkihal closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants