Substantial Agent Search Updates #3994
Merged
+2,120
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evan-danswer
approved these changes
Feb 14, 2025
This was referenced Feb 14, 2025
evan-danswer
approved these changes
Feb 14, 2025
|
|
||
| # Sort by score in descending order, handling None scores | ||
| sorted_sections = sorted( | ||
| unique_sections.values(), key=lambda x: x.center_chunk.score or 0, reverse=True |
There was a problem hiding this comment.
If multiple docs have the same score (say 0) this does not give a unique order
| relevant_doc_ids = [doc.center_chunk.document_id for doc in relevant_docs] | ||
|
|
||
| # Start with relevant docs or fallback to original question docs | ||
| streaming_documents = relevant_docs.copy() |
There was a problem hiding this comment.
no more fallback to original question docs? If so, remove "fallback to" comment
joachim-danswer
force-pushed
the
agent-search-prompt-change-v2_a
branch
from
deb0305 to
89be53c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates:
Here is the linear ticket: https://linear.app/danswer/issue/DAN-1452/agent-search-update
How Has This Been Tested?
Local tests with plenty of questions
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.