feat(metastore): add UpdateRevision method

internal/database/metadata/postgres/revision.go

@@ -72,12 +72,35 @@ func (db *DB) GetRevision(ctx context.Context, opt metadata.GetRevisionOpt) (*ty
 	return &rs, nil
 }
 
+func (db *DB) UpdateRevision(ctx context.Context, opt metadata.UpdateRevisionOpt) (int64, error) {
+	and := make(map[string]interface{})
+	if opt.NewRevision != nil {
+		and["revision"] = *opt.NewRevision
+	}
+	if opt.NewAnchored != nil {
+		and["anchored"] = *opt.NewAnchored
+	}
+	cond, args, err := dbutil.BuildConditions(and, nil)
+	if err != nil {
+		return 0, err
+	}
+	if len(cond) == 0 {
+		return 0, fmt.Errorf("invliad option: nothing to update")
+	}
+	args = append(args, opt.RevisionID)
+
+	query := fmt.Sprintf("UPDATE feature_group_revision SET %s WHERE id = ?", strings.Join(cond, ","))
+	if result, err := db.ExecContext(ctx, db.Rebind(query), args...); err != nil {
+		return 0, err
+	} else {
+		return result.RowsAffected()
+	}
+}
+
 func (db *DB) CreateRevision(ctx context.Context, opt metadata.CreateRevisionOpt) (*types.Revision, error) {
 	query := "INSERT INTO feature_group_revision(group_name, revision, data_table, anchored, description) VALUES ($1, $2, $3, $4, $5) RETURNING *"
 	var revision types.Revision
-
-	err := db.GetContext(ctx, &revision, query, opt.GroupName, opt.Revision, opt.DataTable, opt.Anchored, opt.Description)
-	if err != nil {
+	if err := db.GetContext(ctx, &revision, query, opt.GroupName, opt.Revision, opt.DataTable, opt.Anchored, opt.Description); err != nil {
 		if e2, ok := err.(*pq.Error); ok {
 			if e2.Code == pgerrcode.UniqueViolation {
 				return nil, fmt.Errorf("revision %v already exist", opt.Revision)

internal/database/metadata/postgres/revision_test.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"testing"
+	"time"
 
 	"github.com/oom-ai/oomstore/internal/database/metadata"
 	"github.com/stretchr/testify/assert"
@@ -29,6 +30,56 @@ func TestCreateRevision(t *testing.T) {
 	assert.Nil(t, revision)
 }
 
+func TestUpdateRevision(t *testing.T) {
+	db := initAndOpenDB(t)
+	defer db.Close()
+
+	groupName := "device_baseinfo"
+	revisionTimestamp := time.Now().Unix()
+	opt := metadata.CreateRevisionOpt{
+		GroupName:   groupName,
+		Revision:    revisionTimestamp,
+		DataTable:   "device_bastinfo_20211028",
+		Description: "description",
+	}
+	revision, err := db.CreateRevision(context.Background(), opt)
+	assert.Nil(t, err)
+	assert.Equal(t, int32(1), revision.ID)
+
+	r, err := db.GetRevision(context.Background(), metadata.GetRevisionOpt{
+		GroupName: &groupName,
+		Revision:  &revisionTimestamp,
+	})
+	assert.NoError(t, err)
+
+	newRevison := time.Now().Add(time.Second).Unix()
+	rowsAffected, err := db.UpdateRevision(context.Background(), metadata.UpdateRevisionOpt{
+		RevisionID:  int64(r.ID),
+		NewRevision: &newRevison,
+	})
+	assert.Nil(t, err)
+	assert.Equal(t, int64(1), rowsAffected)
+
+	r, err = db.GetRevision(context.Background(), metadata.GetRevisionOpt{
+		RevisionId: &r.ID,
+	})
+	assert.Nil(t, err)
+	assert.Equal(t, newRevison, r.Revision)
+}
+
+func TestUpdateRevisionWithEmpty(t *testing.T) {
+	db := initAndOpenDB(t)
+	defer db.Close()
+
+	newRevision := int64(0)
+	rowsAffected, err := db.UpdateRevision(context.Background(), metadata.UpdateRevisionOpt{
+		RevisionID:  0,
+		NewRevision: &newRevision,
+	})
+	assert.Nil(t, err)
+	assert.Equal(t, int64(0), rowsAffected)
+}
+
 func TestGetRevision(t *testing.T) {
 	db := initAndOpenDB(t)
 	defer db.Close()

internal/database/metadata/store.go

@@ -31,6 +31,7 @@ type Store interface {
 	ListRevision(ctx context.Context, opt ListRevisionOpt) ([]*types.Revision, error)
 	GetRevision(ctx context.Context, opt GetRevisionOpt) (*types.Revision, error)
 	GetLatestRevision(ctx context.Context, groupName string) (*types.Revision, error)
+	UpdateRevision(ctx context.Context, opt UpdateRevisionOpt) (int64, error)
 	BuildRevisionRanges(ctx context.Context, groupName string) ([]*types.RevisionRange, error)
 
 	io.Closer

internal/database/metadata/types.go

@@ -30,3 +30,9 @@ type ListRevisionOpt struct {
 	GroupName  *string
 	DataTables []string
 }
+
+type UpdateRevisionOpt struct {
+	RevisionID  int64
+	NewRevision *int64
+	NewAnchored *bool
+}