Merge pull request #1099 from oom-ai/move-o

refactor: move -o option from 'get' to 'get online'
oom-ai · Jan 27, 2022 · cb15799 · cb15799
2 parents 5c39dc1 + 1d4037c
commit cb15799
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/oomcli/cmd/get.go b/oomcli/cmd/get.go
@@ -4,17 +4,11 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var getOutput *string
-
 var getCmd = &cobra.Command{
 	Use:   "get",
 	Short: "Get resources",
 }
 
 func init() {
 	rootCmd.AddCommand(getCmd)
-
-	flags := getCmd.PersistentFlags()
-
-	getOutput = flags.StringP("output", "o", ASCIITable, "output format [csv,ascii_table]")
 }
diff --git a/oomcli/cmd/get_online.go b/oomcli/cmd/get_online.go
@@ -15,6 +15,7 @@ import (
 )
 
 var multiGetOpt types.OnlineMultiGetOpt
+var getOnlineOutput *string
 
 var getOnlineCmd = &cobra.Command{
 	Use:   "online",
@@ -29,7 +30,7 @@ var getOnlineCmd = &cobra.Command{
 			exitf("failed getting online features: %+v", err)
 		}
 
-		if err := printOnlineFeatures(featureValues, *getOutput); err != nil {
+		if err := printOnlineFeatures(featureValues, *getOnlineOutput); err != nil {
 			exitf("failed printing online feature values, error %+v\n", err)
 		}
 	},
@@ -45,6 +46,8 @@ func init() {
 
 	flags.StringSliceVar(&multiGetOpt.FeatureNames, "feature", nil, "feature full names")
 	_ = getOnlineCmd.MarkFlagRequired("feature")
+
+	getOnlineOutput = flags.StringP("output", "o", ASCIITable, "output format [csv,ascii_table]")
 }
 
 func printOnlineFeatures(featureValues map[string]*types.FeatureValues, output string) error {