fix(pkg/oomstore): make ExportFeatureValuesOpt.RevisionID required

oom-ai · Nov 12, 2021 · fc58b8d · fc58b8d
1 parent acd677a
commit fc58b8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/pkg/oomstore/export.go b/pkg/oomstore/export.go
@@ -15,13 +15,9 @@ func (s *OomStore) ExportFeatureValues(ctx context.Context, opt types.ExportFeat
 		return nil, nil, err
 	}
 
-	var dataTable string
-	if opt.Revision == nil {
-		revision, err := s.GetRevisionBy(ctx, opt.GroupID, *opt.Revision)
-		if err != nil {
-			return nil, nil, err
-		}
-		dataTable = revision.DataTable
+	revision, err := s.GetRevision(ctx, opt.RevisionID)
+	if err != nil {
+		return nil, nil, err
 	}
 
 	featureNames := opt.FeatureNames
@@ -47,7 +43,7 @@ func (s *OomStore) ExportFeatureValues(ctx context.Context, opt types.ExportFeat
 	}
 
 	stream, err := s.offline.Export(ctx, offline.ExportOpt{
-		DataTable:    dataTable,
+		DataTable:    revision.DataTable,
 		EntityName:   entity.Name,
 		FeatureNames: featureNames,
 		Limit:        opt.Limit,

diff --git a/pkg/oomstore/types/options.go b/pkg/oomstore/types/options.go
@@ -36,7 +36,7 @@ type CreateFeatureGroupOpt struct {
 
 type ExportFeatureValuesOpt struct {
 	GroupID      int16
-	Revision     *int64
+	RevisionID   int32
 	FeatureNames []string
 	Limit        *uint64
 }