Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(featctl/makefile): add release ci #350

Merged
merged 2 commits into from
Nov 4, 2021
Merged

feat(featctl/makefile): add release ci #350

merged 2 commits into from
Nov 4, 2021

Conversation

lianxmfor
Copy link
Member

@lianxmfor lianxmfor commented Nov 4, 2021

this PR will add release ci

close #348

@lianxmfor lianxmfor added the 🚧 wip Work in progress label Nov 4, 2021
@lianxmfor lianxmfor changed the title feat(featctl/makefile): add release command [wip] feat(featctl/makefile): add release command Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #350 (0062f92) into main (64bf7cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   61.70%   61.70%           
=======================================
  Files          33       33           
  Lines        1363     1363           
=======================================
  Hits          841      841           
  Misses        405      405           
  Partials      117      117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64bf7cd...0062f92. Read the comment docs.

@lianxmfor lianxmfor removed the 🚧 wip Work in progress label Nov 4, 2021
@lianxmfor lianxmfor changed the title [wip] feat(featctl/makefile): add release command feat(featctl/makefile): add release command Nov 4, 2021
Copy link
Member

@t0t07 t0t07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wfxr wfxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lianxmfor lianxmfor merged commit 1f897d3 into main Nov 4, 2021
@lianxmfor lianxmfor deleted the add-release branch November 4, 2021 09:29
@lianxmfor lianxmfor changed the title feat(featctl/makefile): add release command feat(featctl/makefile): add release ci Nov 4, 2021
t0t07 pushed a commit that referenced this pull request Dec 20, 2021
feat(featctl/makefile): add release command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Set up ci to release featctl binary automatically
3 participants