Update to latest trunk #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ootwch
force-pushed
the
20221105_no_http_host_pr
branch
from
5629e3f to
7995c19
Compare
…_update_user()`. This addresses an issue in `wp_update_user()`, where `time()` is subtracted from the `$logged_in_cookie['expiration']` of type `string`. Follow-up to [29043]. Props justlevine. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59377 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [https://mu.trac.wordpress.org/changeset/543 mu:543], [https://mu.trac.wordpress.org/changeset/557 mu:557], [12603]. Props jdahir0789, apermo, aboelfotoh. Fixes #62254. git-svn-id: https://develop.svn.wordpress.org/trunk@59378 602fd350-edb4-49c9-b593-d223f7449a82
Removes the dimension suffix, eg `-1000x1000` from the file name of full size images automatically converted from HEIC to JPEGs by WordPress. Introduces unit tests for the default conversion of images and customized conversion settings via the `image_editor_output_format` filter. Follow up to [58849], [58942], [59317], [59346], [59366] Props mukesh27, peterwilsoncc, azaozz, apermo, flixos90, ironprogrammer. Fixes #62359. See #53645, #62305. git-svn-id: https://develop.svn.wordpress.org/trunk@59379 602fd350-edb4-49c9-b593-d223f7449a82
"We missed you", hissed the lovecats. -- The Cure. See #62359. git-svn-id: https://develop.svn.wordpress.org/trunk@59380 602fd350-edb4-49c9-b593-d223f7449a82
After the SimplePie library was updated to version `1.8.0` in [59141], an edge case has been discovered where a fatal error can encountered if the `blog_charset` option is missing or empty. In `fetch_feed()`, this option is retrieved using `get_option()` instead of `get_bloginfo( ‘charset’ )`. The latter will detect this scenario and apply a default value of `UTF-8` and is already used interchangeably throughout Core. This switches to `get_bloginfo( ‘charset’ )` instead to prevent this edge case. Props david.binda, davidbaumwald, SergeyBiryukov, sabernhardt, azaozz, peterwilsoncc. Fixes #62354. git-svn-id: https://develop.svn.wordpress.org/trunk@59382 602fd350-edb4-49c9-b593-d223f7449a82
Props pbiron, peterwilsoncc, fazyshah. Fixes #62150. git-svn-id: https://develop.svn.wordpress.org/trunk@59386 602fd350-edb4-49c9-b593-d223f7449a82
…ent form. Follow-up to [5543], [9436], [11104], [11204], [11739]. Props hiteshhuptechweb, sabernhardt. Fixes #62373. git-svn-id: https://develop.svn.wordpress.org/trunk@59388 602fd350-edb4-49c9-b593-d223f7449a82
When uploading `wav` files in the editor, Chrome and other browsers identify the mime type of the file as `audio/wav`. Firefox, however, identifies the mime type as `audio/x-wav`. This commit updates the `'wav'` mime type key in `wp_get_mime_types()` to support `x-wav` so that uploading wav files work in Firefox. Previously, the editor reported an unsupported mime type error. Props imranh920, ramonopoly. Fixes #61948. git-svn-id: https://develop.svn.wordpress.org/trunk@59389 602fd350-edb4-49c9-b593-d223f7449a82
…e editor. This change makes the border of the pull quote block visible in the editor when the user selects a border color or thickness, by setting the default border style to solid. Props nidhidhandhukiya, ugyensupport, dhruvang21, sabernhardt, divyeshk71, poena. Fixes #62301. git-svn-id: https://develop.svn.wordpress.org/trunk@59390 602fd350-edb4-49c9-b593-d223f7449a82
When the HTML Processor seeks to an earlier place, it returns the the beginning of the document and proceeds forward until it reaches the appropriate location. This requires resetting internal state so that the processor can correctly proceed from the beginning of the document. The seeking reset logic was not adapted to account for the full processor (i.e. when created via `WP_HTML_Processor::create_full_parser()`). This change updates the seek logic to account for the full and fragment parsers as well as other state that has been introduced in the interim and should be reset. Props jonsurrell, dmsnell, westonruter, mi5t4n. Fixes #62290. git-svn-id: https://develop.svn.wordpress.org/trunk@59391 602fd350-edb4-49c9-b593-d223f7449a82
Ensure that `expects_closer` returns `false` on tags that look like void HTML tags, but are actually ''not'' void tags in foreign content. Props jonsurrell, bernhard-reiter. Fixes #62363. git-svn-id: https://develop.svn.wordpress.org/trunk@59392 602fd350-edb4-49c9-b593-d223f7449a82
This updates certain local Docker environment commands to include `--rm`, which instructs `docker compose` to remove the container after running the specified scripts. Previously only the installation script contained `--rm`. But running `test:php`, `env:start`, or `env:cli` resulted in the container remaining. Props johnbillion. Fixes #62395. git-svn-id: https://develop.svn.wordpress.org/trunk@59393 602fd350-edb4-49c9-b593-d223f7449a82
Now that 6.7 is generally available, the upgrade tests no longer need to be run against a pre-release version. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59397 602fd350-edb4-49c9-b593-d223f7449a82
Aligns on the behavior of the negation operator with directives to missing paths in client and in server.
With a directive like the following:
{{{
<div data-wp-bind--hidden="!state.missing.property">
This should be hidden by the <code>hidden</code> attribute.
</div>
}}}
Both server and client will return with this fix:
{{{
<div data-wp-bind--hidden="!state.missing.property" hidden="">
This should be hidden by the <code>hidden</code> attribute.
</div>
}}}
Props jonsurrell, luisherranz.
Fixes #62374.
git-svn-id: https://develop.svn.wordpress.org/trunk@59398 602fd350-edb4-49c9-b593-d223f7449a82
Output DOCTYPE when calling `WP_HTML_Processor::serialize` on a full document that includes a DOCTYPE. The DOCTYPE should be included in the serialized/normalized HTML output as it has an impact in how the document is handled, in particular whether the document should be handled in quirks or no-quirks mode. This only affects the serialization of full parsers at this time because DOCTYPE tokens are currently ignored in all possible fragments. The omission of the DOCTYPE is subtle but can change the serialized document's quirks/no-quirks mode. Props jonsurrell. Fixes #62396. git-svn-id: https://develop.svn.wordpress.org/trunk@59399 602fd350-edb4-49c9-b593-d223f7449a82
Includes: * Wrapping long lines for better readability. * Bringing some consistency to the placement of `href` and `aria-label` attributes. * Adding missing `aria-label` attributes for Live Preview links. Follow-up to [26726], [52020], [51083]. Props patelketan, sainathpoojary, SergeyBiryukov. Fixes #62405. git-svn-id: https://develop.svn.wordpress.org/trunk@59400 602fd350-edb4-49c9-b593-d223f7449a82
The database container is started when the `services` are initially set up. Having a separate step for this sometimes introduces unexpected failures for an unknown reason. Props johnbillion. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59402 602fd350-edb4-49c9-b593-d223f7449a82
The reusable upgrade testing workflow was renamed in [58165], but the event `paths` filters were not updated accordingly. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59403 602fd350-edb4-49c9-b593-d223f7449a82
…nment readme. See #62281 git-svn-id: https://develop.svn.wordpress.org/trunk@59405 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [56416]. Props truptikanzariya. Fixes #62433. git-svn-id: https://develop.svn.wordpress.org/trunk@59406 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [58279]. Props shyamkariya, pitamdey, nareshbheda, ketanniruke, desrosj. Fixes #62434. git-svn-id: https://develop.svn.wordpress.org/trunk@59407 602fd350-edb4-49c9-b593-d223f7449a82
Includes correcting the test class name as per the naming conventions. Follow-up to [59382]. See #62280. git-svn-id: https://develop.svn.wordpress.org/trunk@59408 602fd350-edb4-49c9-b593-d223f7449a82
Adjust some CSS characteristics in the customizer accordions to avoid a slight horizontal scroll, allow the chevron icon to be part of the clickable control surface, and resolve a pre-existing padding issue allowing overflow on accordion headings. Follow up to [59224]. Props laurelfulford, wildworks, domainsupport, sabernhardt, rcreators, desrosj, sainathpoojary. Fixes #62313, #62335. git-svn-id: https://develop.svn.wordpress.org/trunk@59409 602fd350-edb4-49c9-b593-d223f7449a82
Changeset [59399] fixed missing DOCTYPEs in normalized HTML output. It missed an edge case where public and system identifiers may contain double quotes, in which case they must be quoted with single quotes. This commit addresses that issue and adds tests. Follow-up to [59399]. Props jonsurrell, luisherranz, apermo. Fixes #62396. git-svn-id: https://develop.svn.wordpress.org/trunk@59410 602fd350-edb4-49c9-b593-d223f7449a82
This is more consistent with other strings and occurrences of this string. Props juanfra, joen, narenin, mukesh27. See #62414. git-svn-id: https://develop.svn.wordpress.org/trunk@59412 602fd350-edb4-49c9-b593-d223f7449a82
Support for uploading AVIF was added in [57524]. A new block of conditional logic was added determine which function should be used to create the new image file that resulted in these expensive functions being run twice. This combines the two conditional logic to ensure the appropriate function is only run once regardless of format. Props adamsilverstein, glynnquelch. Fixes #62331. git-svn-id: https://develop.svn.wordpress.org/trunk@59413 602fd350-edb4-49c9-b593-d223f7449a82
…Edit Post screen. Props: charleslf, im3dabasia1, desrosj, dhruvang21, Zargarov, sainathpoojary, azaozz Fixes: #62440 git-svn-id: https://develop.svn.wordpress.org/trunk@59414 602fd350-edb4-49c9-b593-d223f7449a82
…pporting browsers. Based on the user agent stylesheet rules outlined in https://html.spec.whatwg.org/multipage/rendering.html#img-contain-size, images that have `sizes=auto` while applying `width: auto` or `width: fit-content` would be constrained to only 300px width. This changeset overrides said user agent stylesheet rule with a much larger constraint, to avoid the problem. Additionally, it introduces a filter `wp_img_tag_add_auto_sizes` which can be used to opt out of the functionality, as an additional measure. Props joemcgill, flixos90, dooperweb, SirLouen, azaozz, mukesh27, apermo. Fixes #62413. See #61847, #62345. git-svn-id: https://develop.svn.wordpress.org/trunk@59415 602fd350-edb4-49c9-b593-d223f7449a82
…outer Remove the workaround for a bug that was fixed in WordPress/gutenberg#66183. Previously, if the store was not initialized with a minimal navigation object, the interactivity-router script module would error. Props jonsurrell, czapla, gziolo. Fixes 62465#. git-svn-id: https://develop.svn.wordpress.org/trunk@59416 602fd350-edb4-49c9-b593-d223f7449a82
…ory Description. This changeset ensures the `target="_blank"` attribute is preserved when adding links in the Biographical Info and Category Description fields. Previously, this attribute was being stripped by the KSES sanitization process. Additionally, new unit tests have been added to verify the preservation of the `target="_blank"` attribute in these specific contexts. Props lovewpmu, miqrogroove, bsutcliffe, sjefen6, nofearinc, nacin, harmr, blogitsolutions, stefahn, nirajgirixd, martinkrcho, spacedmonkey, sukhendu2002, audrasjb, gaellebesson, nuryko, guillaumeturpin, maximemeganck, ranafge, azaozz, joedolson, rinkalpagdar, mikinc860. Fixes #12056. git-svn-id: https://develop.svn.wordpress.org/trunk@59677 602fd350-edb4-49c9-b593-d223f7449a82
… be included. This changeset restricts direct access call in `/wp-admin` and its sub directories. Follow-up to [11768]. Props deepakrohilla. See #61314. git-svn-id: https://develop.svn.wordpress.org/trunk@59678 602fd350-edb4-49c9-b593-d223f7449a82
…Actions workflows files. This includes removing use of dangerous inline GitHub Actions expressions, preventing word splitting, further tightening permissions, and generally improving many aspects of the workflows. This also introduces a new workflow that runs Actionlint to detect incorrect and insecure code and configuration in workflow files. Props johnbillion, swissspidy, flixos90, desrosj. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59679 602fd350-edb4-49c9-b593-d223f7449a82
…er` methods.
This resolves a WPCS warning:
{{{
Variable "$thisEnclosure" is not in valid snake_case format, try "$this_enclosure"
}}}
Follow-up to [16824], [19848].
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59680 602fd350-edb4-49c9-b593-d223f7449a82
The JSON string set as an output for the Slack message payload needs to be one line to prevent causing errors. This ensures `jq` returns a compact JSON string. Follow up to [59679]. Props johnbillion. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59681 602fd350-edb4-49c9-b593-d223f7449a82
This updates `@playwright/test` to the latest version, currently `1.49.1`. In older branches using Playwright, the E2E and Performance workflows have recently started failing. This is due to changes in the GitHub Actions runner images. Updating Playwright ensures more modern dependency trees are used when installing browsers for testing and fixes the issue. Props swissspidy. See #62843. git-svn-id: https://develop.svn.wordpress.org/trunk@59682 602fd350-edb4-49c9-b593-d223f7449a82
…g it to the "Failed Workflow" workflow. Follow-up to [59679]. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59687 602fd350-edb4-49c9-b593-d223f7449a82
…nly be included. This changeset restricts direct access call in `/wp-includes` and its sub directories. Follow-up to [11768], [59678]. Props deepakrohilla. Fixes #61314. git-svn-id: https://develop.svn.wordpress.org/trunk@59688 602fd350-edb4-49c9-b593-d223f7449a82
…a single post object. The `wp-singular` class includes a `wp` prefix to avoid conflicts with existing classes. This changeset also updates the `Tests_Post_GetBodyClass` PHPUnit test to include the new CSS class. Props danielpataki, peterwilsoncc, swissspidy, johnbillion, eceleste, poena, audrasjb, raj198, shailu25. Fixes #35164. git-svn-id: https://develop.svn.wordpress.org/trunk@59689 602fd350-edb4-49c9-b593-d223f7449a82
This changeset deletes the arrow that is typically added next to WordPress admin menu items that have submenus. The `.wp-menu-arrow` element is no longer visible since the WP 3.8 redesign, but the HTML and CSS remained. With this changeset, the HTML generating the arrow is removed, and the corresponding CSS styling is deleted. Props helen, azaozz, jbkkd, pbearne, flixos90. Fixes #26960. git-svn-id: https://develop.svn.wordpress.org/trunk@59690 602fd350-edb4-49c9-b593-d223f7449a82
This changeset clarifies the purpose of these functions and make the documentation more accurate and flexible. Instead of referring to the "date the post was written," the functions and filter descriptions now refer to the "date of the post." This change accommodates scenarios where the displayed date might not strictly correspond to the writing date (e.g. scheduled posts, backdated posts, or content where the "date" represents something other than creation). Props casiepa, audrasjb, SergeyBiryukov, Rarst, helen, azouamauriac, pbearne. Fixes #51289. git-svn-id: https://develop.svn.wordpress.org/trunk@59691 602fd350-edb4-49c9-b593-d223f7449a82
…t_post_time()`. This aims to avoid confusion with `the_date()` and `get_the_date()`. Includes synchronizing the description for `the_weekday()` and `the_weekday_date()`, which have very similar functionality, except that the latter will only output the weekday if the current post's weekday is different from the previous one output. Follow-up to [59691]. See #51289. git-svn-id: https://develop.svn.wordpress.org/trunk@59692 602fd350-edb4-49c9-b593-d223f7449a82
… run within the Slack notifications workflow. Prior to r59679 this value was echoed to GitHub output which meant that its surrounding double quotes lost their significance. Now this value is used directly in the job output it needs to be treated as a plain string. This concludes the conclusion confusion. See #82221 git-svn-id: https://develop.svn.wordpress.org/trunk@59693 602fd350-edb4-49c9-b593-d223f7449a82
Remove the option "Disable the visual editor when writing" from the user profile if it is currently false. If enabled, the option will stay available until disabled. This was blocked due to issues with tab order and focusability in the classic editor environment until [59188]. Props mark-k, SergeyBiryukov, joedolson, pento, iseulde, chriscct7, afercia, prasadkarmalkar, rcreators, jamieblomerus. Fixes #34681. git-svn-id: https://develop.svn.wordpress.org/trunk@59695 602fd350-edb4-49c9-b593-d223f7449a82
Rename the 'Text' tab of the classic editor to 'Code', mimicking the labels used in the block editor: "Visual editor" and "Code editor". Update code comment and Help documentation to reference the editor using the new label. Props lukecavanagh, ctienshi, travel_girl, audrasjb, sabernhardt, joedolson, rseigel, mark-k, sergeybiryukov, presskopp, giuriani, afercia, knutsp, audrasjb, sukhendu2002. Fixes #38061. git-svn-id: https://develop.svn.wordpress.org/trunk@59696 602fd350-edb4-49c9-b593-d223f7449a82
…hods.
This resolves a WPCS warning:
{{{
Variable "$ID" is not in valid snake_case format, try "$i_d"
}}}
Follow-up to [28448].
See #62279.
git-svn-id: https://develop.svn.wordpress.org/trunk@59697 602fd350-edb4-49c9-b593-d223f7449a82
…`body_class`. This changeset introduces new classes to the body tag. The classes `wp-theme-<name>` and `wp-child-theme-<name>` (when the current theme is a child theme) are added, where `<name>` represents the sanitized name of the active theme. Props cais, GaryJ, nacin, SergeyBiryukov, johnjamesjacoby, nirajgirixd, poena, audrasjb, rinkalpagdar. Fixes #19736. git-svn-id: https://develop.svn.wordpress.org/trunk@59698 602fd350-edb4-49c9-b593-d223f7449a82
…_editPost()`. Follow-up to [59697]. Props johnbillion. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59699 602fd350-edb4-49c9-b593-d223f7449a82
This new argument, which defaults to the value of `public`, can be used to determine whether a post can be embedded using oEmbed. A new `is_post_embeddable()` function is added to easily check this. Props pampfelimetten, swissspidy, bradleyt, DrewAPicture, gadelhas, mukesh27. Fixes #35567. git-svn-id: https://develop.svn.wordpress.org/trunk@59700 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces the new `import_filters` action hook at the end of the Import screen, consistently with other admin screens like `export.php`. Props audrasjb, lenasterg. Fixes #54419. See #19863. git-svn-id: https://develop.svn.wordpress.org/trunk@59701 602fd350-edb4-49c9-b593-d223f7449a82
…Docs standards; Props ankitpatel1578, sabernhardt. Fixes #62859. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59702 602fd350-edb4-49c9-b593-d223f7449a82
Since [13683], `the_shortlink()` has included a `title` attribute. By default, that gives the sanitized post title, and it does not sanitize custom text. Given the low value of this attribute, this changeset removes it. Props sabernhardt, audrasjb, joedolson. Fixes #62838. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59703 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds more details on the `WP_Term` returned by `get_category()` as it contains additional backwards compatible aliases for the era before WP 4.4 and 2.3. Props apermo, audrasjb. Fixes #62842. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59704 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces the light grey background color with the white color defined in the Editor Storybook. This change also impacts admin color schemes that previously utilized the default admin background color. This is an initial implementation of the WordPress design system, aligning with the broader goal of achieving a more consistent and unified design across the administration. Props karmatosed, audrasjb. Fixes #62831. git-svn-id: https://develop.svn.wordpress.org/trunk@59705 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes a margin issue in the search input box on the Add New Plugins screen, which was previously breaking below 1138px. Specifically, the top margin was set to 0px, and the overall appearance of the search box was inconsistent between 1000px and 1138px. Now, the margin is consistent across all breakpoints. Props jomonthomaslobo1, narenin, iflairwebtechnologies, peterwilsoncc, audrasjb, shailu25. Fixes #61785. git-svn-id: https://develop.svn.wordpress.org/trunk@59706 602fd350-edb4-49c9-b593-d223f7449a82
…_post()`. Follow-up to [19848]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59707 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes an UI issue where the theme count in the "Add Themes" screen touches the top border on small screens. Props sukhendu2002, diliphingarajiya, dilipbheda, ankitkumarshah, dhruvang21, im3dabasia1. Fixes #62499. git-svn-id: https://develop.svn.wordpress.org/trunk@59708 602fd350-edb4-49c9-b593-d223f7449a82
This changeset lowers the font-weight value from `600` to `400` for labels located in the Settings screens. This is an initial implementation of the WordPress design system, aligning with the broader goal of achieving a more consistent and unified design across the administration. Props karmatosed, audrasjb. Fixes #62865. git-svn-id: https://develop.svn.wordpress.org/trunk@59709 602fd350-edb4-49c9-b593-d223f7449a82
…e_comment()`. Follow-up to [20856]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59710 602fd350-edb4-49c9-b593-d223f7449a82
This changeset replaces `title` attributes with `aria-label` for weekdays in `get_calendar()` table cells. Props sabernhardt, audrasjb, mukesh27, shailu25. Fixes #62860. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59711 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest trunk