Add string case check to ObjectReader parser. Fixes #90

oozcitak · Jul 28, 2021 · 299f1a3 · 299f1a3
1 parent 9ca72f1
commit 299f1a3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/readers/ObjectReader.ts b/src/readers/ObjectReader.ts
@@ -28,7 +28,7 @@ export class ObjectReader extends BaseReader<ExpandObject> {
       lastChild = this.parse(node, obj.apply(this))
     } else if (isArray(obj) || isSet(obj)) {
       forEachArray(obj, item => lastChild = this.parse(node, item), this)
-    } else /* if (isMap(obj) || isObject(obj)) */ {
+    } else if (isMap(obj) || isObject(obj)) {
       // expand if object
       forEachObject(obj, (key, val) => {
         if (isFunction(val)) {
@@ -127,6 +127,11 @@ export class ObjectReader extends BaseReader<ExpandObject> {
           lastChild = this.element(node, undefined, this.sanitize(key)) || lastChild
         }
       }, this)
+    } else if (!options.keepNullNodes && (obj == null)) {
+      // skip null and undefined nodes
+    } else {
+      // text node
+      lastChild = this.text(node, this.sanitize(obj)) || lastChild
     }
 
     return lastChild || node

diff --git a/test/issues/issue-090.test.ts b/test/issues/issue-090.test.ts
@@ -13,7 +13,7 @@ describe("Replicate issue", () => {
       }
     };
     const doc = $$.create().ele(obj2);
-    expect(doc.end({ prettyPrint: true})).toBe(`
+    expect(doc.end({ headless: true, prettyPrint: true})).toBe($$.t`
     <monologue>
       Talk to me Goose!
       <cut>dog tag shot</cut>