feat(client): Account + Account storage hinting in TrieDB
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2024
Merged
clabby
force-pushed
the
cl/trie-hints
branch
2 times, most recently
from
8495f68 to
3f457af
Compare
clabby
force-pushed
the
cl/output-root-generation
branch
from
bc40428 to
5bb3e43
Compare
refcell
approved these changes
Jun 11, 2024
Adds a function to the block executor that allows for generating the current output root, based on the parent timestamp and current trie.
Introcues the `TrieDBHinter` trait, which outlines an interface for sending hints to the host for trie account proofs and storage slot proofs. This enables `kona-host` to use `eth_getProof` rather than the very limited `debug_dbGet` for fetching account proofs during L2 execution.
This was referenced Jun 11, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introcues the
TrieDBHintertrait, which outlines an interface for sending hints to the host for trie account proofs and storage slot proofs. This enableskona-hostto useeth_getProofrather than the very limiteddebug_dbGetfor fetching most of the intermediate trie nodes during L2 execution.Caveat: We do still need some sort of trie-node-by-hash function in order to fetch siblings within branches during node deletion.
debug_dbGetworks for hash-scheme geth nodes, though it is the only option at the moment. Might be time to build an indexer on reth to cache intermediate trie nodes.