Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host): Ensure prefetch is falliable #740

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 28, 2024

Overview

Doesn't throw a hard error if the prefetch operation fails, but retries it and notifies the logs of the failure.

@clabby clabby requested a review from refcell as a code owner October 28, 2024 16:47
@clabby
Copy link
Collaborator Author

clabby commented Oct 28, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Oct 28, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
311 1 310 0
View the full list of 1 ❄️ flaky tests
kona-mpt list_walker::test::test_online_list_walker_receipts

Flake rate in main: 36.36% (Passed 28 times, Failed 16 times)

Stack Traces | 0.098s run time
thread 'list_walker::test::test_online_list_walker_receipts' panicked at .../mpt/src/list_walker.rs:183:85:
called `Result::unwrap()` on an `Err` value: HTTP error 429 with body: {"code":-32007,"message":"5/second request limit reached - reduce calls per second or upgrade your account at quicknode.com"}

Caused by:
    HTTP error 429 with body: {"code":-32007,"message":"5/second request limit reached - reduce calls per second or upgrade your account at quicknode.com"}
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@clabby clabby self-assigned this Oct 28, 2024
@clabby clabby added K-feature Kind: feature A-host Area: host binary labels Oct 28, 2024
@clabby clabby changed the base branch from cl/remove-max-retries to main October 28, 2024 17:12
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs restack on trunk

@clabby clabby force-pushed the cl/handle-prefetch-err branch from 931dbba to 7448939 Compare October 28, 2024 17:12
@clabby clabby enabled auto-merge October 28, 2024 17:13
@clabby clabby added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit a75fd7d Oct 28, 2024
14 of 15 checks passed
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants