-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reduce MSRV #867
chore: Reduce MSRV #867
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
a3da4d1
to
154fe0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, but also should decrement the rust-version
in the workspace's Cargo.toml
.
@hashcashier can you make the requested change so we can get this merged? Currently need to point to your repo when integrating with Kailua, would love to get rid of dependency hell by having this merged. Seems like you'll need to revert the changes in #859 to bring down the MSRV to 1.81, and potentially add some comments or use nightly version to shutup some lint warnings. |
This is needed until op-rs/kona#867 is merged
Sorry I'd lost track of this. Should be good to go now. |
@clabby can we merge this? |
Yeah, apologies for the long turnaround. On vacation atm. |
@clabby figured! Thanks for merging this, enjoy your break haha. |
is_none_or
is stable as of Rust 1.82, while the RISC Zero zkvm toolchain is currently using 1.81This patch introduces more verbose code to bring the MSRV back down to 1.81 to avoid compiling with unstable features.
Generally it would also be great if Kona could have an MSRV policy set (e.g. MSRV is always at least 2 versions behind) to help avoid these issues.