Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce MSRV #867

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: Reduce MSRV #867

merged 1 commit into from
Dec 20, 2024

Conversation

hashcashier
Copy link
Contributor

is_none_or is stable as of Rust 1.82, while the RISC Zero zkvm toolchain is currently using 1.81

This patch introduces more verbose code to bring the MSRV back down to 1.81 to avoid compiling with unstable features.

Generally it would also be great if Kona could have an MSRV policy set (e.g. MSRV is always at least 2 versions behind) to help avoid these issues.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.6%. Comparing base (8f21eff) to head (d39b314).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hashcashier hashcashier force-pushed the kailua branch 2 times, most recently from a3da4d1 to 154fe0b Compare December 5, 2024 18:28
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, but also should decrement the rust-version in the workspace's Cargo.toml.

@samlaf
Copy link
Contributor

samlaf commented Dec 18, 2024

@hashcashier can you make the requested change so we can get this merged? Currently need to point to your repo when integrating with Kailua, would love to get rid of dependency hell by having this merged.

Seems like you'll need to revert the changes in #859 to bring down the MSRV to 1.81, and potentially add some comments or use nightly version to shutup some lint warnings.

samlaf added a commit to Layr-Labs/hokulea that referenced this pull request Dec 18, 2024
@hashcashier
Copy link
Contributor Author

Sorry I'd lost track of this. Should be good to go now.

@samlaf
Copy link
Contributor

samlaf commented Dec 19, 2024

@clabby can we merge this?

@clabby
Copy link
Collaborator

clabby commented Dec 20, 2024

@clabby can we merge this?

Yeah, apologies for the long turnaround. On vacation atm.

@clabby clabby added this pull request to the merge queue Dec 20, 2024
Merged via the queue into op-rs:main with commit 7a40d87 Dec 20, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
@samlaf
Copy link
Contributor

samlaf commented Dec 20, 2024

@clabby figured! Thanks for merging this, enjoy your break haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants