Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Isthmus Withdrawals Root #881

Merged
merged 2 commits into from
Jan 3, 2025
Merged

chore: Isthmus Withdrawals Root #881

merged 2 commits into from
Jan 3, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jan 3, 2025

Description

Updates kona's stateless block executor to set the withdrawals root to the L2 to L1 message passer account when isthmus is active.

Specs: https://specs.optimism.io/protocol/isthmus/exec-engine.html#l2tol1messagepasser-storage-root-in-header

@refcell
Copy link
Collaborator Author

refcell commented Jan 3, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell requested a review from clabby as a code owner January 3, 2025 20:58
@refcell refcell self-assigned this Jan 3, 2025
@refcell refcell added K-chore Kind: chore A-executor Area: kona-executor crate H-isthmus Hardfork: Isthmus related labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.6%. Comparing base (3ad8e4d) to head (ffd9a5a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/executor/mod.rs 47.3% 10 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/executor/src/executor/mod.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from clabby January 3, 2025 22:21
@clabby clabby added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 7015026 Jan 3, 2025
15 of 16 checks passed
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate H-isthmus Hardfork: Isthmus related K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants