[OPAL-9309] Use TypeSet for visibility_groups and group_ids
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsy-opal
force-pushed
the
andrewsy/opal-9309-ignore-visibility-group-order
branch
from
6205137 to
44565db
Compare
andrewsy-opal
changed the title
visibility_groups
andrewsy-opal
changed the title
visibility_groupsvisibility_groups and group_ids
aashish-opal
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Currently, for certain fields, we use
TypeListwhich compares order when doingterraform planthis diff updatesvisibility_groupsingroupandresourceas well asgroup_idsinrequest_configurationto be order agnostic, since they are commutative.Checklist