Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an [examples] variant to PyPartMC requirements in setup.py to avoid hacky logic in CI workflow and enable users to pip-install these dependencies #305

Closed
slayoo opened this issue Nov 25, 2023 · 1 comment
Closed

add an [examples] variant to PyPartMC requirements in setup.py to avoid hacky logic in CI workflow and enable users to pip-install these dependencies #305

slayoo opened this issue Nov 25, 2023 · 1 comment
Labels
no-activity

Comments

@slayoo
Copy link
Member

slayoo commented Nov 25, 2023

currently we have this in the workflow file:

          ex -sc 'g/^PyPartMC/d' -cx .binder/requirements.txt
          pip install -r .binder/requirements.txt

and no way for a user to pip-install these dependencies
@slayoo slayoo added this to the v1.0.0 milestone Nov 25, 2023
@slayoo slayoo removed this from the v1.0.0 milestone Dec 12, 2023
@github-actions GitHub Actions
Copy link

Stale issue message

@slayoo slayoo changed the title add an [examples] varint to PyPartMC requirements in setup.py to avoid hacky logic in CI workflow and enable users to pip-install these dependencies add an [examples] variant to PyPartMC requirements in setup.py to avoid hacky logic in CI workflow and enable users to pip-install these dependencies Feb 3, 2025
slayoo added a commit to slayoo/PyPartMC that referenced this issue Feb 3, 2025
@slayoo
Add "examples" variant for pip installation including dependencies ne…
cd3f603 
…eded for examples, mention in README, and use in .binder/requirements.txt file. Closes open-atmos#305
@slayoo slayoo closed this as completed in 964b20d Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slayoo