-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve input_state by returning populated data structures #364
Conversation
@jcurtis2, do we need to have these empty constructors exposed in Python? IIUC, objects constructed this way are not usable. Would it be possible instead to have these empty constructors only in C++, and expose some read-from-file factory methods returning usable Python objects? |
CI fails on those setups where the freshly released SciPy 1.14.0 is used, which is due to an incompatibility on PyMieScatt side caused by scipy/scipy#20278 Reported upstream: bsumlin/PyMieScatt#25 For the time being, adding a constraint on version of SciPy to the setup.py file (only for CI) |
Returning data structures rather than passing them in as arguments. This is useful for when using
input_state
to read input from a output files where the user has no advanced knowledge ofAeroData
,GasData
, etc. Previously the user would have to provide some amount of minimal information to their constructors (such as a single species toAeroData
as done intest_aero_data.py
, etc.).Previously you'd need some minimal information (that would actually be overwritten by
input_state
):