Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change units to SI for radii array in Bolin table_1.ipynb #1493

Closed
wants to merge 1 commit into from

Conversation

AgnieszkaZaba
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (824a94d) to head (9c8cd53).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         376      376           
  Lines        9266     9266           
=======================================
  Hits         7897     7897           
  Misses       1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo
Copy link
Member

slayoo commented Jan 8, 2025

@AgnieszkaZaba, the original code seems more intuitive as it matches what's in the paper's table column 1

@AgnieszkaZaba
Copy link
Collaborator Author

@AgnieszkaZaba, the original code seems more intuitive as it matches what's in the paper's table column 1

So maybe rename it to radii_cm?

@slayoo
Copy link
Member

slayoo commented Jan 8, 2025

@AgnieszkaZaba, the original code seems more intuitive as it matches what's in the paper's table column 1

So maybe rename it to radii_cm?

Since we multiply the values by si.cm, what get stored into the variable is in metres, hence such name would be misleading.

@AgnieszkaZaba
Copy link
Collaborator Author

Closing as unnecessary:)

@AgnieszkaZaba AgnieszkaZaba deleted the bolin branch January 9, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants