Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create deploiement-continu-avec-circleci--partie-1.md #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jean-smaug
Copy link

@jean-smaug jean-smaug commented Jul 5, 2019

What is the purpose of your pull request ?

  • new blog post.
  • bug fix
  • new feature for Open Blog

Describe your PR content

pseudo: jeansmaug
date: 2019-03-19 # A valid date corresponding to the publish date
title: Déploiement continu avec CircleCI - Partie 1
hero: ./assets/enseigner-autrement.jpeg # Required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove comments

- CircleCi
- CD
- Firebase
commentIssueId: 31 # Id of a issue that will keep comments about your post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue here in not related to your article

date: 2019-03-19 # A valid date corresponding to the publish date
title: Déploiement continu avec CircleCI - Partie 1
hero: ./assets/enseigner-autrement.jpeg # Required
description: Déployer une application VueJS sur Firebase hosting avec CircleCI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description could be longer to help your reader find it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants