-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timing functionality #295
Add timing functionality #295
Conversation
0b52ec7
to
9f70e6a
Compare
de60210
to
fbda2f7
Compare
fbda2f7
to
2bc5bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoaa this is super nice! I've added a bunch of thoughts, let me know what you think please.
There are some styling inconsistencies (but these aren't defined anywhere!), so I'll fix them up when we've agreed on the discussion below.
18c911e
to
3487f83
Compare
@gustavohenke thanks for the feedback, I've applied it, let me know if you see anything else |
6da8b2c
to
596c9de
Compare
Co-authored-by: Gustavo Henke <[email protected]>
596c9de
to
7eb0499
Compare
@gustavohenke the test coverage being almost 100% was annoying me so I've added a few tests to cover the remaining lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM, I'm just implementing a logger-friendly console.table
and will push directly to your branch.
We need to respect a bunch of other combinations users can have (raw mode, using a custom stdout, etc)
Add timing functionality to resolve #291