Allow all policy types to use hub templates

The framework-addon will handle the reporting of the hub template errors, it is not necessary for each controller to consider them. Refs: - https://issues.redhat.com/browse/ACM-10858 Signed-off-by: Justin Kulikauskas <[email protected]>
open-cluster-management-io · Apr 29, 2024 · 66971b0 · 66971b0
1 parent 1f8a6f0
commit 66971b0
Showing 1 changed file with 0 additions and 24 deletions.
diff --git a/controllers/propagator/propagation.go b/controllers/propagator/propagation.go
@@ -269,22 +269,6 @@ func (r *ReplicatedPolicyReconciler) processTemplates(
 			continue
 		}
 
-		if !isConfigurationPolicy(policyT) {
-			// has Templates but not a configuration policy
-			err := k8serrors.NewBadRequest("Templates are restricted to only Configuration Policies")
-			log.Error(err, "Not a Configuration Policy")
-
-			r.Recorder.Event(rootPlc, "Warning", "PolicyPropagation",
-				fmt.Sprintf(
-					"Policy %s/%s has templates but it is not a ConfigurationPolicy.",
-					rootPlc.GetName(),
-					rootPlc.GetNamespace(),
-				),
-			)
-
-			return err
-		}
-
 		log.V(1).Info("Found an object definition with templates")
 
 		templateContext := templateCtx{ManagedClusterName: clusterName}
@@ -427,11 +411,3 @@ func (r *ReplicatedPolicyReconciler) processTemplates(
 
 	return nil
 }
-
-func isConfigurationPolicy(policyT *policiesv1.PolicyTemplate) bool {
-	// check if it is a configuration policy first
-	var jsonDef map[string]interface{}
-	_ = json.Unmarshal(policyT.ObjectDefinition.Raw, &jsonDef)
-
-	return jsonDef != nil && jsonDef["kind"] == "ConfigurationPolicy"
-}