Stop returning unexpected errors to the user when parsing query args

It's better to log this rather than expose this to the user since it can lead to confusing error messages. Signed-off-by: mprahl <[email protected]>
open-cluster-management-io · Apr 5, 2024 · e0edfb4 · e0edfb4
1 parent e028c99
commit e0edfb4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/controllers/complianceeventsapi/server.go b/controllers/complianceeventsapi/server.go
@@ -921,7 +921,9 @@ func getComplianceEvents(db *sql.DB, w http.ResponseWriter,
 			return
 		}
 
-		writeErrMsgJSON(w, err.Error(), http.StatusInternalServerError)
+		log.Error(err, "parsing the query arguments unexpectedly failed")
+
+		writeErrMsgJSON(w, "Internal Error", http.StatusInternalServerError)
 
 		return
 	}
@@ -1214,7 +1216,9 @@ func getComplianceEventsCSV(db *sql.DB, w http.ResponseWriter, r *http.Request,
 			return
 		}
 
-		writeErrMsgJSON(w, queryArgsErr.Error(), http.StatusInternalServerError)
+		log.Error(queryArgsErr, "parsing the query arguments unexpectedly failed")
+
+		writeErrMsgJSON(w, "Internal Error", http.StatusInternalServerError)
 
 		return
 	}