Add -1 as a possible compliance value for the status metric

ref: https://issues.redhat.com/browse/ACM-11504 Signed-off-by: Jason Zhang <[email protected]>
open-cluster-management-io · May 14, 2024 · e43515b · e43515b
1 parent 839923e
commit e43515b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/controllers/policymetrics/metrics.go b/controllers/policymetrics/metrics.go
@@ -11,7 +11,7 @@ import (
 var policyStatusGauge = prometheus.NewGaugeVec(
 	prometheus.GaugeOpts{
 		Name: "policy_governance_info",
-		Help: "The compliance status of the named policy. 0 == Compliant. 1 == NonCompliant",
+		Help: "The compliance status of the named policy. 0 == Compliant. 1 == NonCompliant. -1 == Unknown/Pending",
 	},
 	[]string{
 		"type",              // "root" or "propagated"

diff --git a/controllers/policymetrics/policymetrics_controller.go b/controllers/policymetrics/policymetrics_controller.go
@@ -130,6 +130,8 @@ func (r *MetricReconciler) Reconcile(ctx context.Context, request ctrl.Request)
 		statusMetric.Set(0)
 	} else if pol.Status.ComplianceState == policiesv1.NonCompliant {
 		statusMetric.Set(1)
+	} else {
+		statusMetric.Set(-1)
 	}
 
 	return reconcile.Result{}, nil