Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the code to generate disabled compliance events for local-cluster #215

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented Apr 15, 2024

This is now handled in the governance-policy-framework-addon: open-cluster-management-io/governance-policy-framework-addon#132

Relates:
https://issues.redhat.com/browse/ACM-10418

@mprahl mprahl force-pushed the fix-flaky-disable branch from 68af653 to b29f249 Compare April 15, 2024 19:45
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold in case you need to coordinate the merging

Copy link

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Member Author

mprahl commented Apr 17, 2024

/unhold

@dhaiducek
Copy link
Member

/hold

1 similar comment
@mprahl
Copy link
Member Author

mprahl commented Apr 17, 2024

/hold

@mprahl
Copy link
Member Author

mprahl commented Apr 18, 2024

/unhold

@mprahl mprahl merged commit 0a78fa3 into open-cluster-management-io:main Apr 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants