Document the spec.hubTemplateOptions.serviceAccountName field #239
Conversation
api/v1/policy_types.go
Outdated
| // A service account in the same namespace as the policy to use for all hub template lookups. The service account | ||
| // must have list and watch permissions on any object the hub templates lookup. If not specified, | ||
| // lookups are restricted to namespaced objects in the same namespace as the policy and the ManagedCluster object | ||
| // the policy is propagated to. |
There was a problem hiding this comment.
| // A service account in the same namespace as the policy to use for all hub template lookups. The service account | |
| // must have list and watch permissions on any object the hub templates lookup. If not specified, | |
| // lookups are restricted to namespaced objects in the same namespace as the policy and the ManagedCluster object | |
| // the policy is propagated to. | |
| // ServiceAccountName is the name of a service account in the same namespace as the policy to use for all hub template lookups. The service account | |
| // must have list and watch permissions on any object the hub templates look up. If not specified, | |
| // lookups are restricted to namespaced objects in the same namespace as the policy and the `ManagedCluster` object | |
| // the policy is propagated to. |
There was a problem hiding this comment.
Could you clean this up also? I'm not actually sure what the second part of this is saying about the ManagedCluster object. I think this might be clearer?
lookups are restricted to namespaced objects in the same namespace as the policy and to the ManagedCluster object associated with the propagated policy.
|
/hold for reviews |
Relates: https://issues.redhat.com/browse/ACM-13572 Signed-off-by: mprahl <[email protected]>
|
Thanks @dhaiducek! Your suggestions sound better. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 166702f
into
open-cluster-management-io:main
Relates:
https://issues.redhat.com/browse/ACM-13572