🐛 move the rebootstrap logic to registration agent #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 61.06% 61.13% +0.06%
==========================================
Files 129 129
Lines 13771 13661 -110
==========================================
- Hits 8409 8351 -58
+ Misses 4588 4549 -39
+ Partials 774 761 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
ee94897 to
fa91d13
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
fa91d13 to
f2c3e19
Compare
elgnay
changed the title
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
f2c3e19 to
cae4ce2
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
cae4ce2 to
e34e716
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
3 times, most recently
from
79a095d to
9c13dac
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
9c13dac to
b000388
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
5 times, most recently
from
5ed032f to
4df38d3
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
4df38d3 to
d2993e8
Compare
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
2 times, most recently
from
4e04a07 to
085b461
Compare
Signed-off-by: Yang Le <[email protected]>
elgnay
force-pushed
the
terminate-on-bootstrpkubeconfig
branch
from
085b461 to
abfda59
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elgnay, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the initial bootstrap hub kubeconfig is invalid, for example with wrong proxy settings, the bootstrap will not succeed and no hub kubeconfig will be created. Once a new bootstrap hub kubeconfig is provided by updating the bootstrap-kubeconfig-secret, the rebootstrapping will not be triggered because the klusterlet operator does not know if the bootstrap hub kubeconfig has changed.
By adding a new health checker, the agent will restart once bootstrap hub kubeconfig secret changes. That fix the issue described above. Another health checker is added as well to restart agent when the client certificate become expired.
Summary
Related issue(s)
Fixes #