Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/paste typo in SingleConnectionSocketServerTransport ? #70

Closed
sbernard31 opened this issue Oct 23, 2023 · 2 comments
Closed

Copy/paste typo in SingleConnectionSocketServerTransport ? #70

sbernard31 opened this issue Oct 23, 2023 · 2 comments

Comments

@sbernard31
Copy link
Collaborator

There is maybe some copy/paste typo in SingleConnectionSocketServerTransport ?

Should it be ?

-    private static final Logger LOGGER = LoggerFactory.getLogger(SingleConnectionSSLSocketServerTransport.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(SingleConnectionSocketServerTransport.class);
-           LOGGER.debug("SSLSocketServer is listening on " + serverSocket.getLocalSocketAddress());
+           LOGGER.debug("ServerSocket is listening on " + serverSocket.getLocalSocketAddress());
@sbernard31
Copy link
Collaborator Author

Same kind of issue in SocketClientTransport

-    private static final Logger LOGGER = LoggerFactory.getLogger(SSLSocketClientTransport.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(SocketClientTransport.class);

@szysas
Copy link
Collaborator

szysas commented Oct 31, 2023

Good catch, yes, it is a typo.

szysas added a commit that referenced this issue Nov 7, 2023
szysas added a commit that referenced this issue Nov 7, 2023
@szysas szysas closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants