-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying API keys globally for site and instance #8
Conversation
4515c70
to
62d02cc
Compare
6e7f0db
to
fa3e7b2
Compare
#### Security Considerations | ||
|
||
For better security, we recommend using site configuration or Django settings instead of configuring API keys at the | ||
XBlock level. This prevents API keys from being exposed in course exports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Agrendalath Thank you for noting this!
@Agrendalath Looks great! Only one thing is that |
fa3e7b2
to
daf785b
Compare
@ArturGaspar, sure thing - added in 7577830. Edit: a quick heads-up that I had to rebase this PR to convert the unit test from 52fe3e4. |
This also fixes model URL field data validation.
daf785b
to
7577830
Compare
👍
|
Description
This implements the option to specify the API key for each model via:
Testing instructions
Other information
In the first two commits, I:
Self
. I double-checked that the client does not use this version.pytest
to avoid mixingmark.parametrize
fromtest_compat.py
andddt
in the same repository. It's a general platform's direction to usepytest
tests.Private-ref: BB-9551